Skip to content

Fixes TICS violations in wayland_connector.cpp#4804

Open
DigraJatin wants to merge 2 commits intocanonical:mainfrom
DigraJatin:fix/resolve-TICS-violations-wayland_connector-4711
Open

Fixes TICS violations in wayland_connector.cpp#4804
DigraJatin wants to merge 2 commits intocanonical:mainfrom
DigraJatin:fix/resolve-TICS-violations-wayland_connector-4711

Conversation

@DigraJatin
Copy link
Copy Markdown
Contributor

@DigraJatin DigraJatin commented Mar 30, 2026

Closes #4711

What's new?

Resolved TICS violations in mentioned file.

  1. reinterpret_cast -> static_cast
  2. initialized earlier uninitalized variable eventfd_t ignored{};
  3. added overload for WlClient::from to accept const client.

@DigraJatin DigraJatin requested a review from a team as a code owner March 30, 2026 17:26
Copy link
Copy Markdown
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I think this could be simpler (and avoid const_cast<>) by taking a wl_client const* everywhere instead; client.cpp never needs a non-const wl_client, so we can just store wl_client const* and not need the overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve TICS violations in wayland_connector.cpp

2 participants