patch(upgrades): event-agnostic backup/restore checks#235
Open
patch(upgrades): event-agnostic backup/restore checks#235
Conversation
The upgrades objects must be created last in the refreshes so that all other managers required are created before they are accessed. This is because the refreshes entirely run in the __init__ function of the refresh objects, which prevents access to objects that are created after this object is created…
This reverts commit 49fba9c.
Gu1nness
changed the title
Gu1nness
force-pushed
the
fix/refreshes-objects-order
branch
from
902ef30 to
458a4ff
Compare
Gu1nness
force-pushed
the
fix/refreshes-objects-order
branch
from
89af926 to
950b4de
Compare
patriciareinoso
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷️ Type of changes
📝 Description
Two issues where raised with a bug that affects upgrades.
If the charm is integrated with a backup solution, then the pre-refresh checks are failing from the get go because the backup_events object does not exist yet when the charm tries to access it.
This is fixed by adding some helper methods to check if backup/restore is in progress.
Closes: canonical/mongodb-k8s-operator#502
Closes: canonical/mongodb-operator#639
🧪 Manual testing steps
🔬 Automated testing steps
Not yet added / To be discussed.
✅ Checklist