gui: enforce default close behavior when unset (Fixes #4506) #4521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When onAppCloseKey has no stored preference, Multipass would show incorrect default behavior. This patch enforces the default 'ask' behavior when the preference is empty or missing. Signed-off-by: vardhan30016 <vardhannaidu17@gmail.com>
Author
|
Thanks for the update! Yes, this PR is still in progress — currently waiting for a maintainer review and approval. Once a maintainer reviews and approves the workflow, the remaining checks will run and the PR can move forward toward merging. Let me know if anything else is needed from my side! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #4506, where the default close behavior was not reflected
in the GUI when the setting
onAppCloseKeywas not set.Root cause
closeJobwas read from settings but not given a default when missing.Fix
closeJobis null or empty, enforce the default action"ask".Result
Multipass GUI now behaves correctly when first installed or when the user has
no stored preference.
Fixes #4506
— @vardhan30016