[ci] Use different action to avoid rate limiting #4596
Conversation
ricab
left a comment
ricab
left a comment
There was a problem hiding this comment.
Nice! This makes sense to me and the code looks good.
Although the action is not hugely popular (71 stars now), it looks pretty sane to me and the workflow already restricts permissions as much as possible. We could pin a specific sha instead of a version, to avoid tags moving from under us, but this is not special in that regard.
I have a question inline and I would ask for evidence that this is working properly. Could you provide a link to a successful run please? Did you try dry-run first?
|
@ricab Yes, this action is not as relatively popular, but I really didn't want to have to manually call the GitHub API through a script. I did a couple of test runs. The first failed due to GitHub rate limiting as it was catching up with deleting old packages. It is available here. I manually ran the workflow again which successfully cleaned up the remaining packages. It is available here. |
Right, I didn't mean to suggest anything like that.
OK, thank you. |
ricab
left a comment
ricab
left a comment
There was a problem hiding this comment.
LGTM, thanks for this improvement!
Switching out the GitHub action used for deleting old package version as cached by vcpkg. The previous action,
actions/delete-package-versions, can only handle one package at a time, so a matrix was used to apply the action to all the packages that Multipass uses. GitHub matrices, however, only support up to 256 entries and with moving more dependencies to vcpkg, we are already hitting this limits.This PR instead uses the
smartsquaregmbh/delete-old-packagesaction which takes a list of packages and apply the operation to all of them at once.This may hit GitHub API rate limiting, but running the workflow again will pick where the last run failed.