Open
Conversation
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xz-embedded does not have an official vcpkg port yet. This patch adds a minimal vcpkg port for our use-case. Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
Signed-off-by: Mustafa Kemal Gilor <mustafa.gilor@canonical.com>
xmkg
force-pushed
the
enhancement/move-xz-embedded-to-vcpkg
branch
from
0e653d3 to
94e321f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4734 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 258 258
Lines 14124 14124
=======================================
Hits 12379 12379
Misses 1745 1745 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Any idea how hard it would be to upstream this? Just out of curiosity 😄 |
Member
Author
That already crossed my mind, too. It would require a much more elaborate portfile, but we could try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move xz-embedded to vcpkg by adding a minimal portfile for it. The portfile is required bc vcpkg has no official port for it.
It's needed for the "streamlining dependencies" initiative we have.
MULTI-2342