Skip to content

Conversation

rpbritton
Copy link

@rpbritton rpbritton commented Jun 26, 2025

Issue

Since provides endpoints can be non-optional, can the default value of optional is false, these endpoints are assumed non-optional.

Solution

Set optional flag on provides endpoint to indicate correct optionality.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

Copy link

codecov bot commented Jun 26, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rpbritton, in principle there's nothing wrong, but can you explain the concept/motivation here?

@paulomach
Copy link
Contributor

@rpbritton also, please rebase to pick fix in tests

@rpbritton
Copy link
Author

Hi @rpbritton, in principle there's nothing wrong, but can you explain the concept/motivation here?

Hi @paulomach , the context here is for automated Charm testing we need to deduce the minimal deployment using these flags for the test (so they should reflect which integrations are required to successfully deploy the charm, a neighboring charm, and test the integration between them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants