[DPE-7322] Support predefined roles #652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
added
the
enhancement
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
17 times, most recently
from
350dc94 to
90bb3c8
Compare
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
2 times, most recently
from
2bb4cdc to
ef8e039
Compare
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
3 times, most recently
from
d6ef3e2 to
0d020f4
Compare
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
6 times, most recently
from
e9ba0fb to
8000b34
Compare
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
2 times, most recently
from
2c8e14b to
bd05e71
Compare
Comment on lines
+1516
to
+1518
| if len(role_name) >= ROLE_MAX_LENGTH: | ||
| logger.warning(f"Pruning application database role name {role_name}") | ||
| role_name = role_name[:ROLE_MAX_LENGTH] |
There was a problem hiding this comment.
This snippet is here to decouple this PR from changes that will be proposed on the MySQL Test app.
In short: there is a length limit on how roles can be named in MySQL (32 characters). MySQL Test app default database name is continuous_writes_database, which in addition to the charmed_dba prefix surpasses the limit. I would suggest shorten the default database name to just continuous_writes.
sinclert-canonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
taurus-forever
approved these changes
Aug 19, 2025
paulomach
approved these changes
Aug 29, 2025
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
from
bd05e71 to
77207f7
Compare
|
PR branch rebased from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the set of predefined roles proposed in this specification.
In addition to the predefined roles proposed to be on sync with PostgreSQL 16 operators, there is an additional one in order to solve a long time standing time debt:
mysqlrouter. This predefined role is proposed in order to stop treating mysqlrouter as a magic word used to assignALL PRIVILEGESto the created users whoseextra-user-rolesconfig argument contained such word. That exact name has been chosen to preserve backwards compatibility.Additional changes:
extra-user-rolesconfig argument._) instead of mixing dashes and underscores.