[DPE-7322] Support predefined roles #269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
added
the
enhancement
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
4 times, most recently
from
03dc3c6 to
3d1f6a2
Compare
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
from
3d1f6a2 to
ec166ee
Compare
sinclert-canonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
| @@ -150,6 +170,23 @@ def add_attributes_to_mysql_router_user( | |||
| self._run_sql([f"ALTER USER `{username}` ATTRIBUTE '{attributes}'"]) | |||
| logger.debug(f"Added {attributes=} to {username=}") | |||
|
|
|||
| # TODO python3.10 min version: Use `set` instead of `typing.Set` | |||
| def get_mysql_roles(self, name_pattern: str) -> typing.Set[str]: | |||
There was a problem hiding this comment.
Suggested change
| def get_mysql_roles(self, name_pattern: str) -> typing.Set[str]: | |
| def _get_mysql_roles(self, name_pattern: str) -> typing.Set[str]: |
nit
Comment on lines
-128
to
+131
| def create_application_database_and_user(self, *, username: str, database: str) -> str: | ||
| """Create database and user for related database_provides application.""" | ||
| def create_application_database(self, *, database: str) -> str: |
There was a problem hiding this comment.
on the public interface (of mysql_shell), could we keep this as one method since it should always be called together?
e.g. if you want to have it split into two functions internally, suggest something like
def create_application_database_and_user():
self._create_application_database()
self._create_application_user()
Comment on lines
+24
to
+25
| ROLE_DML = "charmed_dml" | ||
| ROLE_READ = "charmed_read" |
There was a problem hiding this comment.
Suggested change
| ROLE_DML = "charmed_dml" | |
| ROLE_READ = "charmed_read" | |
| _ROLE_DML = "charmed_dml" | |
| _ROLE_READ = "charmed_read" |
nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports the set of predefined roles proposed in this specification.