[DPE-7322] Support predefined roles #269
Conversation
sinclert-canonical
added
the
enhancement
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
4 times, most recently
from
03dc3c6 to
3d1f6a2
Compare
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
from
3d1f6a2 to
ec166ee
Compare
sinclert-canonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
src/mysql_shell/__init__.py
Outdated
| def create_application_database_and_user(self, *, username: str, database: str) -> str: | ||
| """Create database and user for related database_provides application.""" | ||
| def create_application_database(self, *, database: str) -> str: |
There was a problem hiding this comment.
on the public interface (of mysql_shell), could we keep this as one method since it should always be called together?
e.g. if you want to have it split into two functions internally, suggest something like
def create_application_database_and_user():
self._create_application_database()
self._create_application_user()There was a problem hiding this comment.
I think having a function with two lines of code is an oversimplification and provides little value. Furthermore, 1/2 usages are within an interface that will be pruned soon (deprecated_shared_db_provides.py module).
There was a problem hiding this comment.
function with two lines of code is an oversimplification and provides little value
would you be willing to combine it back into one method then?
I'd like to keep the public interface of mysql_shell the same (1 method) since the methods should always be called together
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
from
ec166ee to
597219c
Compare
sinclert-canonical
force-pushed
the
sinclert/7322/predefined-roles
branch
from
597219c to
ed11918
Compare
This PR supports the set of predefined roles proposed in this specification.