feat: add ability to scrape log files by name#128
feat: add ability to scrape log files by name#128arturo-seijas wants to merge 10 commits intocanonical:mainfrom
Conversation
sed-i
changed the title
sed-i
left a comment
sed-i
left a comment
There was a problem hiding this comment.
Thanks for the PR, this looks promising!
There was a problem hiding this comment.
Note that this charmib is owned by the grafana agent charm, end eventually, before this PR merges, we would need to have this change merged there first.
There was a problem hiding this comment.
I'll open a PR once this one has the green light
There was a problem hiding this comment.
@javierdelapuente has been able to test this and confirms that the logs are exported as expected. When setting a log file from /var/log, the files are exported twice, via the old mechanism and also via the new. We consider that to be out of scope of the PR. If you are ok with this, I'll open a PR in the grafana agent charm with the lib change
Co-authored-by: Leon <82407168+sed-i@users.noreply.github.com> Signed-off-by: arturo-seijas <102022572+arturo-seijas@users.noreply.github.com>
sed-i
left a comment
sed-i
left a comment
There was a problem hiding this comment.
Looking good, thanks!
Would you be able to open a tandem PR on some principal charm to confirm this works as intended?
2 participants
Issue
Fixes #120
Solution
Context
Testing Instructions
Upgrade Notes