fix: eslint CI fixes #935

yanksyoon · 2026-02-12T12:14:56Z

Applicable spec:

Overview

Swap out broken ncc with more modern esbuild
Introduce basic testing for typscript modules

Rationale

ncc build is broken
we might forget to build and push when typescript actions modules are updated

Workflow Changes

Checklist

The contributing guide was applied
The PR is tagged with appropriate label (urgent, trivial, complex)
The changelog is updated with user-relevant changes in the format of keep a changelog v1.1.0

This reverts commit 97b0c04.

github-actions

license-eye has checked 144 files.

Valid	Invalid	Ignored	Fixed
31	1	112	0

Click to see the invalid file list

eslint.config.cjs

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

eslint.config.cjs

tsconfig.json

package.json

seb4stien · 2026-02-13T06:59:00Z

.github/workflows/workflow_simple_test.yaml

+      - name: Verify no build changes
+        run: |
+          if ! git --no-pager diff --exit-code -- dist/; then
+            echo "Build output differs under dist/. Run 'npm run package' locally and commit changes."


Are we sure that builds are 100% reproducibles? Maybe just checking if there a file that has been modified more recently in the sources than in the dist would do the job? And it may be faster (I didn't check how long is the build though).

It should be reproducible if same node version is used (tested), the other dependencies should be pinned using package-lock.json, if this test fails, the packages should be rebuilt and if it should be rebuilt, i believe every sources should be rebuilt along with it, not just the changed files. WDYT?

docs/changelog.md

src/plan.ts

github-actions · 2026-02-13T10:43:32Z

Test results for commit `b670f73`

Test coverage for b670f73

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-02-13 10:39:19.965221+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-02-13T10:43:32Z

Test results for commit `b670f73`

Test coverage for b670f73

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-02-13 10:39:21.127199+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-02-13T10:43:33Z

Test results for commit `b670f73`

Test coverage for b670f73

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-02-13 10:40:20.156707+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-02-13T10:43:51Z

Test results for commit `b670f73`

Test coverage for b670f73

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-02-13 10:39:19.965221+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-02-13T10:43:52Z

Test results for commit `b670f73`

Test coverage for b670f73

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-02-13 10:39:21.127199+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-02-13T10:43:52Z

Test results for commit `b670f73`

Test coverage for b670f73

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       8      8      0      0     0%   8-25
----------------------------------------------------------
TOTAL              8      8      0      0     0%

Static code analysis report

Run started:2026-02-13 10:40:20.156707+00:00

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 56
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

github-actions · 2026-02-13T10:43:58Z

Unused entries in .trivyignore

Image: ghcr.io/canonical/test-foo:73ebae26eaf71e0462669ed86b00b03f1351934e-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

github-actions · 2026-02-13T10:44:37Z

Unused entries in .trivyignore

Image: ghcr.io/canonical/test-foo:73ebae26eaf71e0462669ed86b00b03f1351934e-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

github-actions · 2026-02-13T10:44:38Z

Unused entries in .trivyignore

Image: ghcr.io/canonical/test:a8ba9319ad0fe10278b87cf705838818e280ccdd-_1.0_amd64

The following CVEs are in .trivyignore but not ignored by Trivy anymore:

yanksyoon added 9 commits February 12, 2026 10:43

fix: eslint update related fixes

d6528d4

docs: changelog

e7fa704

Revert "fix: eslint update related fixes"

9e52435

This reverts commit 97b0c04.

fix: eslint errors

184a664

fix: update bundler to ESM

e90a5a8

fix: minor syntax issues

a5709cf

chore: build dist

e26340f

ci: add testing

0fc2d1b

ci: build changes diff

1f6a89e

github-actions bot reviewed Feb 12, 2026

View reviewed changes

eslint.config.cjs Outdated Show resolved Hide resolved

yanksyoon added 6 commits February 12, 2026 12:16

ci: add copyright

15b10aa

ci: build w/ matching node version

1c88e06

ci: remove test (no unit tests)

3da4407

docs: update changelog

ccdb62b

chore: replace ncc w/ esbuild

78c25ca

chore: build

922d1d8

yanksyoon marked this pull request as ready for review February 13, 2026 06:19

yanksyoon requested a review from a team as a code owner February 13, 2026 06:19

yanksyoon requested review from DeeKay3 and amandahla and removed request for a team February 13, 2026 06:19

alithethird reviewed Feb 13, 2026

View reviewed changes

tsconfig.json Outdated Show resolved Hide resolved

alithethird reviewed Feb 13, 2026

View reviewed changes

package.json Outdated Show resolved Hide resolved

alithethird approved these changes Feb 13, 2026

View reviewed changes

yanksyoon added 2 commits February 13, 2026 06:50

fix: newline

998e8a7

fix: eslint warnings

eb33e7f

seb4stien reviewed Feb 13, 2026

View reviewed changes

docs/changelog.md Outdated Show resolved Hide resolved

seb4stien reviewed Feb 13, 2026

View reviewed changes

src/plan.ts Show resolved Hide resolved

seb4stien approved these changes Feb 13, 2026

View reviewed changes

fix: minor issues

4f39fe7

DeeKay3 approved these changes Feb 13, 2026

View reviewed changes

ci: fixes

b670f73

fix: eslint CI fixes #935

Are you sure you want to change the base?

fix: eslint CI fixes #935

Conversation

yanksyoon commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Rationale

Workflow Changes

Checklist

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

seb4stien Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

yanksyoon Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026

Test results for commit b670f73

Uh oh!

github-actions bot commented Feb 13, 2026

Test results for commit b670f73

Uh oh!

github-actions bot commented Feb 13, 2026

Test results for commit b670f73

Uh oh!

github-actions bot commented Feb 13, 2026

Test results for commit b670f73

Uh oh!

github-actions bot commented Feb 13, 2026

Test results for commit b670f73

Uh oh!

github-actions bot commented Feb 13, 2026

Test results for commit b670f73

Uh oh!

github-actions bot commented Feb 13, 2026

Unused entries in .trivyignore

Uh oh!

github-actions bot commented Feb 13, 2026

Unused entries in .trivyignore

Uh oh!

github-actions bot commented Feb 13, 2026

Unused entries in .trivyignore

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yanksyoon commented Feb 12, 2026 •

edited

Loading

Test results for commit `b670f73`

Test results for commit `b670f73`

Test results for commit `b670f73`

Test results for commit `b670f73`

Test results for commit `b670f73`

Test results for commit `b670f73`