[MISC] Set Pgbackrest spool dir to archive mount #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1025 +/- ##
===========================================
+ Coverage 72.33% 72.35% +0.01%
===========================================
Files 14 14
Lines 3680 3682 +2
Branches 524 524
===========================================
+ Hits 2662 2664 +2
Misses 821 821
Partials 197 197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
taurus-forever
approved these changes
Jul 3, 2025
| @@ -1813,7 +1813,8 @@ def test_render_pgbackrest_conf_file(harness, tls_ca_chain_filename): | |||
| storage_path=harness.charm._storage_path, | |||
| user="backup", | |||
| retention_full=30, | |||
| process_max=max(cpu_count() - 2, 1), | |||
| process_max=2, | |||
There was a problem hiding this comment.
We should be getting the number of available cores from get_available_resources() in case of fractional limits and the output of it is patched above.
dragomirp
commented
Jul 3, 2025
| @@ -1184,6 +1185,7 @@ def _render_pgbackrest_conf_file(self) -> bool: | |||
| # Open the template pgbackrest.conf file. | |||
| with open("templates/pgbackrest.conf.j2") as file: | |||
| template = Template(file.read()) | |||
| cpu_count, _ = self.charm.get_available_resources() | |||
There was a problem hiding this comment.
Get CPU from the helper to manage fractional limits.
|
Please excuse me, I was wrong, we need put spool dir to the same volume as WAL dir, but not inside WAL dir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set spool path in Pgbackrest config to use the archive volume when restoring
Checklist