Skip to content

Port predefined roles changes from VM charm and use the single kernel library #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: 16/edge
Choose a base branch
from
Draft

Port predefined roles changes from VM charm and use the single kernel library #1049

wants to merge 4 commits into from

Conversation

marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Aug 5, 2025 •
edited
Loading

Issue

Solution

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@marceloneppel marceloneppel added the enhancement New feature, UI change, or workload upgrade label Aug 5, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 5, 2025
View reviewed changes
tests/integration/jubilant_helpers.py
"""
secret = get_secret_by_label(label=f"{PEER}.{database_app_name}.app")
password = secret.get(f"{username}-password")
print(f"Retrieved password for {username}: {password}")

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High test

This expression logs
sensitive data (secret)
Loading
as clear text.
This expression logs
sensitive data (password)
Loading
as clear text.
This expression logs
sensitive data (secret)
Loading
as clear text.
This expression logs
sensitive data (secret)
Loading
as clear text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature, UI change, or workload upgrade Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marceloneppel