[DPE-9444] Switch to ops tracing (16/edge) by dragomirp · Pull Request #1264 · canonical/postgresql-k8s-operator

dragomirp · 2026-02-16T15:18:54Z

Switch to ops tracing and remove the old charm libs.

Checklist

I have added or updated any relevant documentation.
I have cleaned any remaining cloud resources from my accounts.

codecov · 2026-02-16T15:20:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.96%. Comparing base (f2aeb85) to head (4c05c50).

❌ Your project check has failed because the head coverage (68.96%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           16/edge    #1264      +/-   ##
===========================================
- Coverage    68.97%   68.96%   -0.01%     
===========================================
  Files           16       16              
  Lines         3816     3809       -7     
  Branches       575      574       -1     
===========================================
- Hits          2632     2627       -5     
+ Misses         982      980       -2     
  Partials       202      202

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

dragomirp · 2026-02-19T13:28:12Z

src/charm.py

-@trace_charm(
-    tracing_endpoint="tracing_endpoint",
-    extra_types=(
-        GrafanaDashboardProvider,
-        LogProxyConsumer,
-        MetricsEndpointProvider,
-        Patroni,
-        PostgreSQL,
-        PostgreSQLAsyncReplication,
-        PostgreSQLBackups,
-        PostgreSQLLDAP,
-        PostgreSQLProvider,
-        TLS,
-        RollingOpsManager,
-    ),
-)


There's no shared auto-instrumentation. Traces would show up as juju hooks.

do individual ops events (e.g. if there's more than one ops event in a juju hook) show up?

if not, does the tracing add any value? since we can get timings from the debug-log

I am planning a talk with Ops team the next office house (to restore profiling capabilities without re-implementing it in charm).

yes, it is a functional regression, but ops[tracing] if currently focused on distributed tracing and not on charm profiling. Anyway we have to migrate as charm lib has been deprecated and CVE affected.

to restore profiling capabilities

I'm not sure how useful they were initially (never used in production afaik because of the overhead), and they came at a cost of harder to understand tracebacks. I think detailed profiling could be interesting, but using an approach similar to parca—i.e. sampling instead of tracing; not modifying the workload

what I was wondering is what the existing ops tracing currently adds over the debug log

Ops creates the root span and a separate span when calling each observer

https://documentation.ubuntu.com/ops/latest/explanation/tracing/

it sounds like multiple ops events in a juju event are traced separately? not sure if I am understanding correctly

do individual ops events (e.g. if there's more than one ops event in a juju hook) show up?

if not, does the tracing add any value? since we can get timings from the debug-log

It's a mixed bag, IMHO. We get more details from ops itself, but less from the charm code:

According to https://documentation.ubuntu.com/ops/latest/explanation/tracing/#division-of-responsibilities only some of the charm code is expected to be instrumented.

oh it's nice the hook commands are instrumented!

dragomirp · 2026-02-19T15:29:13Z

poetry.lock

 [[package]]
 name = "protobuf"
-version = "4.25.8"
+version = "6.33.5"


Updated protobuf.

src/charm.py

carlcsaposs-canonical · 2026-02-20T08:32:59Z

src/charm.py

-@trace_charm(
-    tracing_endpoint="tracing_endpoint",
-    extra_types=(
-        GrafanaDashboardProvider,
-        LogProxyConsumer,
-        MetricsEndpointProvider,
-        Patroni,
-        PostgreSQL,
-        PostgreSQLAsyncReplication,
-        PostgreSQLBackups,
-        PostgreSQLLDAP,
-        PostgreSQLProvider,
-        TLS,
-        RollingOpsManager,
-    ),
-)


do individual ops events (e.g. if there's more than one ops event in a juju hook) show up?

if not, does the tracing add any value? since we can get timings from the debug-log

taurus-forever · 2026-02-20T11:47:59Z

src/charm.py

-@trace_charm(
-    tracing_endpoint="tracing_endpoint",
-    extra_types=(
-        GrafanaDashboardProvider,
-        LogProxyConsumer,
-        MetricsEndpointProvider,
-        Patroni,
-        PostgreSQL,
-        PostgreSQLAsyncReplication,
-        PostgreSQLBackups,
-        PostgreSQLLDAP,
-        PostgreSQLProvider,
-        TLS,
-        RollingOpsManager,
-    ),
-)


I am planning a talk with Ops team the next office house (to restore profiling capabilities without re-implementing it in charm).

yes, it is a functional regression, but ops[tracing] if currently focused on distributed tracing and not on charm profiling. Anyway we have to migrate as charm lib has been deprecated and CVE affected.

src/charm.py

metadata.yaml

marceloneppel · 2026-02-20T16:27:27Z

pyproject.toml

This comment can be removed, right? If so, I believe it can also be removed in canonical/pgbouncer-k8s-operator#687 and #1279.

Switch to ops tracing

e123d9e

dragomirp added the enhancement New feature, UI change, or workload upgrade label Feb 16, 2026

github-actions bot added the Libraries: OK The charm libs used are OK and in-sync label Feb 16, 2026

dragomirp added 2 commits February 17, 2026 02:08

Remover tracing lib

9c8c831

Merge branch '16/edge' into dpe-9444-tracing

abfe3b3

dragomirp commented Feb 19, 2026

View reviewed changes

Bump protobuf

0f8e068

dragomirp commented Feb 19, 2026

View reviewed changes

poetry.lock

[[package]]

name = "protobuf"

version = "4.25.8"

version = "6.33.5"

Copy link

Contributor Author

dragomirp Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated protobuf.

dragomirp marked this pull request as ready for review February 19, 2026 15:30

dragomirp requested review from a team, carlcsaposs-canonical, juju-charm-bot, marceloneppel and taurus-forever and removed request for a team February 19, 2026 15:30

Add different tls transfer relation

f8eb179

dragomirp commented Feb 19, 2026

View reviewed changes

src/charm.py Outdated Show resolved Hide resolved

carlcsaposs-canonical previously approved these changes Feb 20, 2026

View reviewed changes

taurus-forever reviewed Feb 20, 2026

View reviewed changes

Don't set tls transfer

53df177

dragomirp dismissed carlcsaposs-canonical’s stale review via 53df177 February 20, 2026 12:56

github-actions bot added Libraries: Out of sync The charm libs used are out-of-sync and removed Libraries: OK The charm libs used are OK and in-sync labels Feb 20, 2026

marceloneppel reviewed Feb 20, 2026

View reviewed changes

Remove dep comment

4c05c50

dragomirp changed the title ~~[DPE-9444] Switch to ops tracing~~ [DPE-9444] Switch to ops tracing (16/edge) Feb 21, 2026

Comments

Conversation

dragomirp commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecov bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dragomirp commented Feb 16, 2026 •

edited

Loading

codecov bot commented Feb 16, 2026 •

edited

Loading