[draft] Use s3-integrator from 2/edge channel with s3 charm lib v1#1280
Draft
theoctober19th wants to merge 12 commits into16/edgefrom
Draft
[draft] Use s3-integrator from 2/edge channel with s3 charm lib v1#1280theoctober19th wants to merge 12 commits into16/edgefrom
theoctober19th wants to merge 12 commits into16/edgefrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (68.97%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1280 +/- ##
========================================
Coverage 68.97% 68.97%
========================================
Files 16 16
Lines 3816 3816
Branches 575 575
========================================
Hits 2632 2632
Misses 982 982
Partials 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to upgrade the postgres charm in 16/edge to use the new s3 charm lib, and also bump to use charm from 2/edge in the CI.
The PR also releases the charm on a test branch on channel
16/edge/prso that we can then test this charm in the s3-integrator integration tests.Checklist