Open
Conversation
github-actions
bot
added
the
Libraries: OK
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
==========================================
- Coverage 72.76% 72.73% -0.03%
==========================================
Files 16 16
Lines 4130 4126 -4
Branches 606 607 +1
==========================================
- Hits 3005 3001 -4
Misses 897 897
Partials 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
Libraries: Out of sync
dragomirp
commented
Feb 20, 2026
| PostgreSQLGetPostgreSQLVersionError, | ||
| ) | ||
| from ops.charm import ( | ||
| from ops import ( |
Contributor
Author
There was a problem hiding this comment.
Import from ops directly, not strictly necessary.
dragomirp
commented
Feb 20, 2026
Comment on lines
+1054
to
+1055
| if not self.upgrade.idle: | ||
| return |
Contributor
Author
There was a problem hiding this comment.
If upgrade is not idle, don't overwrite the status.
dragomirp
requested review from
a team,
carlcsaposs-canonical,
juju-charm-bot,
marceloneppel and
taurus-forever
and removed request for
a team
carlcsaposs-canonical
approved these changes
Feb 20, 2026
marceloneppel
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Unit status during upgrade gets overwritten, hiding from the user that upgrade did not complete
Solution
Add a check for upgrade idleness in the helper method
Checklist