Skip to content

[DPE-6752] Implement instance level predefined roles #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 16/edge
Choose a base branch
from

Conversation

shayancanonical
Copy link
Contributor

@shayancanonical shayancanonical commented May 7, 2025

Issue

VM PR 881 introduces a change to implement instance level predefined roles. These changes, along with updates to the postgresql charmlib, need to be ported over to this repository.

Solution

Port over implementation

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@shayancanonical shayancanonical changed the base branch from main to 16/edge May 7, 2025 16:43
@shayancanonical shayancanonical added the enhancement New feature, UI change, or workload upgrade label May 7, 2025
@shayancanonical shayancanonical marked this pull request as ready for review May 7, 2025 17:00
@shayancanonical shayancanonical force-pushed the feature/16_predefined_instance_roles branch from 50bf787 to 572a634 Compare May 7, 2025 17:57
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.91%. Comparing base (4ce6826) to head (f301d6f).

Files with missing lines Patch % Lines
src/charm.py 50.00% 6 Missing ⚠️
src/upgrade.py 14.28% 6 Missing ⚠️
src/relations/postgresql_provider.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge     #970      +/-   ##
===========================================
- Coverage    72.16%   71.91%   -0.25%     
===========================================
  Files           14       14              
  Lines         3693     3707      +14     
  Branches       525      526       +1     
===========================================
+ Hits          2665     2666       +1     
- Misses         829      841      +12     
- Partials       199      200       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marceloneppel marceloneppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes also LGTM! Thanks for bumping the library to V1. This way, we can avoid legacy code in the new PG 16 codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, UI change, or workload upgrade Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants