-
Notifications
You must be signed in to change notification settings - Fork 23
[DPE-6752] Implement instance level predefined roles #970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16/edge
Are you sure you want to change the base?
Conversation
50bf787
to
572a634
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #970 +/- ##
===========================================
- Coverage 72.16% 71.91% -0.25%
===========================================
Files 14 14
Lines 3693 3707 +14
Branches 525 526 +1
===========================================
+ Hits 2665 2666 +1
- Misses 829 841 +12
- Partials 199 200 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes also LGTM! Thanks for bumping the library to V1. This way, we can avoid legacy code in the new PG 16 codebase.
Issue
VM PR 881 introduces a change to implement instance level predefined roles. These changes, along with updates to the postgresql charmlib, need to be ported over to this repository.
Solution
Port over implementation
Checklist