[DPE-3217] Update Snap to 14.10 + housekeeping (cleanup) (#316)

* Update snap to 14.10 and disable landscape tests

* Skip instead of make unstable

* Outdated locales

* Update Patroni config in one go

* Cleanup after moving Peer Data usage to data_platform_libs/data_interfaces

---------

Co-authored-by: Judit Novak <[email protected]>

Author: dragomirp

lib/charms/data_platform_libs/v0/data_secrets.py

@@ -12,7 +12,6 @@
 
 from charms.data_platform_libs.v0.data_interfaces import DataPeer, DataPeerUnit
 from charms.data_platform_libs.v0.data_models import TypedCharmBase
-from charms.data_platform_libs.v0.data_secrets import SecretCache
 from charms.grafana_agent.v0.cos_agent import COSAgentProvider
 from charms.operator_libs_linux.v2 import snap
 from charms.postgresql_k8s.v0.postgresql import (
@@ -102,7 +101,6 @@ class PostgresqlOperatorCharm(TypedCharmBase[CharmConfig]):
     def __init__(self, *args):
         super().__init__(*args)
 
-        self.secrets = SecretCache(self)
         self.peer_relation_app = DataPeer(
             self,
             relation_name=PEER,
@@ -1391,11 +1389,11 @@ def update_config(self, is_creating_backup: bool = False) -> bool:
 
         self._validate_config_options()
 
-        self._patroni.update_parameter_controller_by_patroni(
-            "max_connections", max(4 * os.cpu_count(), 100)
-        )
-        self._patroni.update_parameter_controller_by_patroni(
-            "max_prepared_transactions", self.config.memory_max_prepared_transactions
+        self._patroni.bulk_update_parameters_controller_by_patroni(
+            {
+                "max_connections": max(4 * os.cpu_count(), 100),
+                "max_prepared_transactions": self.config.memory_max_prepared_transactions,
+            }
         )
 
         restart_postgresql = self.is_tls_enabled != self.postgresql.is_tls_enabled()

src/charm.py

@@ -623,15 +623,15 @@ def reinitialize_postgresql(self) -> None:
         requests.post(f"{self._patroni_url}/reinitialize", verify=self.verify)
 
     @retry(stop=stop_after_attempt(3), wait=wait_exponential(multiplier=1, min=2, max=10))
-    def update_parameter_controller_by_patroni(self, parameter: str, value: Any) -> None:
+    def bulk_update_parameters_controller_by_patroni(self, parameters: Dict[str, Any]) -> None:
         """Update the value of a parameter controller by Patroni.
 
         For more information, check https://patroni.readthedocs.io/en/latest/patroni_configuration.html#postgresql-parameters-controlled-by-patroni.
         """
         requests.patch(
             f"{self._patroni_url}/config",
             verify=self.verify,
-            json={"postgresql": {"parameters": {parameter: value}}},
+            json={"postgresql": {"parameters": parameters}},
         )
 
     def update_synchronous_node_count(self, units: int = None) -> None:

src/cluster.py

@@ -32,7 +32,7 @@
 # Snap constants.
 PGBACKREST_EXECUTABLE = "charmed-postgresql.pgbackrest"
 POSTGRESQL_SNAP_NAME = "charmed-postgresql"
-SNAP_PACKAGES = [(POSTGRESQL_SNAP_NAME, {"revision": "89"})]
+SNAP_PACKAGES = [(POSTGRESQL_SNAP_NAME, {"revision": "95"})]
 
 SNAP_COMMON_PATH = "/var/snap/charmed-postgresql/common"
 SNAP_CURRENT_PATH = "/var/snap/charmed-postgresql/current"

src/constants.py

@@ -1016,7 +1016,7 @@ def test_restart(self, _are_all_members_ready, _restart_postgresql):
     @patch("charm.snap.SnapCache")
     @patch("charms.rolling_ops.v0.rollingops.RollingOpsManager._on_acquire_lock")
     @patch("charm.Patroni.reload_patroni_configuration")
-    @patch("charm.Patroni.update_parameter_controller_by_patroni")
+    @patch("charm.Patroni.bulk_update_parameters_controller_by_patroni")
     @patch("charm.PostgresqlOperatorCharm._validate_config_options")
     @patch("charm.Patroni.member_started", new_callable=PropertyMock)
     @patch("charm.PostgresqlOperatorCharm._is_workload_running", new_callable=PropertyMock)