[DPE-7302] Prefixes #1238
[DPE-7302] Prefixes #1238
Conversation
github-actions
bot
added
the
Libraries: Out of sync
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1238 +/- ##
===========================================
- Coverage 70.73% 70.02% -0.72%
===========================================
Files 16 16
Lines 4042 4133 +91
Branches 629 654 +25
===========================================
+ Hits 2859 2894 +35
- Misses 991 1032 +41
- Partials 192 207 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if self.charm.unit.is_leader(): | ||
| return json.loads(self.charm.app_peer_data.get("rel_databases", "{}")) | ||
|
|
||
| def _get_credentials(self, event: DatabaseRequestedEvent) -> tuple[str, str] | None: |
There was a problem hiding this comment.
Split off, to reduce McCabe.
| return | ||
| return f"relation-{event.relation.id}", new_password() | ||
|
|
||
| def _collect_databases( |
There was a problem hiding this comment.
Split off, to reduce McCabe.
| self.add_database_to_prefix_mapping(database) | ||
| return database, databases | ||
|
|
||
| def _are_units_in_sync(self) -> bool: |
There was a problem hiding this comment.
Split off, to reduce McCabe.
| if event.prefix_matching and event.prefix_matching != "all": | ||
| logger.warning("Only all prefix matching is supported") | ||
| databases = sorted(self.charm.postgresql.list_databases(database[:-1])) | ||
| self.set_databases_prefix_mapping(event.relation.id, user, database[:-1], databases) |
There was a problem hiding this comment.
Set the initial prefixed DB cache.
| else: | ||
| databases = [database] | ||
| # Add to cached field to be able to generate hba rules | ||
| self.add_database_to_prefix_mapping(database) |
There was a problem hiding this comment.
Check and append to existing prefix caches.
| self.database_provides.delete_relation_data( | ||
| relation_id, ["uris", "read-only-uris"] | ||
| ) |
There was a problem hiding this comment.
On prefix DB that matches nothing, unset the URIs, since there's no possible valid value.
| username: str | ||
| prefix: str | ||
| databases: list[str] |
There was a problem hiding this comment.
Cached prefix metadata. We need to know the username to update Postgresql roles and connect grant, we need to know the prefix, to match against when adding database.
| (dbs := self.get_rel_to_db_mapping()) | ||
| and (database := dbs.get(str(event.relation.id))) | ||
| and database[-1] != "*" |
There was a problem hiding this comment.
Use peer data cache of rel to DBs, since at this point the relation data (and the db name in it) should be gone.
github-actions
bot
added
Libraries: OK
| (dbs := self.get_rel_to_db_mapping()) | ||
| and (database := dbs.get(str(event.relation.id))) | ||
| and database[-1] != "*" |
taurus-forever
left a comment
taurus-forever
left a comment
There was a problem hiding this comment.
We should mention ions docs about mandatory 3 symbols prefix before * regexp.
Add support for prefix databases.
Depends on:
Checklist