Skip to content

Conversation

@marceloneppel
Copy link
Member

@marceloneppel marceloneppel commented Dec 1, 2025

Issue

We forgot that we need to split parameters by a hyphen when the config option follows the new format

Solution

Add the split by a hyphen logic.

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

marceloneppel and others added 2 commits December 1, 2025 11:00
We forgot that we need to split parameters by hyphen when the config option follows the new format
@onkolahmet onkolahmet marked this pull request as ready for review December 1, 2025 14:13
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.42%. Comparing base (1313241) to head (681b3f9).
⚠️ Report is 1 commits behind head on 16/edge.

Files with missing lines Patch % Lines
single_kernel_postgresql/utils/postgresql.py 33.33% 2 Missing and 2 partials ⚠️

❌ Your project status has failed because the head coverage (49.42%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           16/edge      #48      +/-   ##
===========================================
- Coverage    49.65%   49.42%   -0.23%     
===========================================
  Files            4        4              
  Lines          860      864       +4     
  Branches        99      101       +2     
===========================================
  Hits           427      427              
- Misses         415      417       +2     
- Partials        18       20       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@onkolahmet onkolahmet requested review from a team, carlcsaposs-canonical, dragomirp, onkolahmet and taurus-forever and removed request for a team December 1, 2025 14:14
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
@marceloneppel marceloneppel changed the title Handle parameters with hyphen [DPE-8997] Handle parameters with hyphen Dec 1, 2025
@onkolahmet onkolahmet merged commit 5a321bd into 16/edge Dec 2, 2025
6 of 7 checks passed
@marceloneppel marceloneppel deleted the handle-build-parameters-with-hyphen branch December 2, 2025 12:07
carlcsaposs-canonical added a commit to canonical/postgresql-k8s-operator that referenced this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants