Skip to content

chore(storybook): move styles to storybook folder#420

Open
goulinkh wants to merge 2 commits intomainfrom
svelte-launchpad-storybook-styles
Open

chore(storybook): move styles to storybook folder#420
goulinkh wants to merge 2 commits intomainfrom
svelte-launchpad-storybook-styles

Conversation

@goulinkh
Copy link
Contributor

PR readiness check

  • PR should have one of the following labels:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • PR title follows the Conventional Commits format.
  • All packages define the required scripts in package.json:
    • All packages: check, check:fix, and test.
    • Packages with build steps: build to build the package for development or distribution, build:all to build all artifacts. See CONTRIBUTING.md for details.

@advl
Copy link
Contributor

advl commented Feb 12, 2026

LGTM but what is the rationale for the change ? Also should we do similarly for other packages ?

@goulinkh
Copy link
Contributor Author

@advl this is related to the launchpad design tokens, where the end project is expected to do these imports.
In the case of storybook, it is considered as an end project so it is doing the imports for it self, the old place for these css files was confusing since they are only included inside the storybook.

@goulinkh
Copy link
Contributor Author

This entire logic is specific to Svelte app tier packages that are using Launchpad design tokens, and will be replaced with the new set of tokens eventually and align with React architecture.

@advl
Copy link
Contributor

advl commented Feb 12, 2026

Yes. I do think though that we could do this for other packages. The end the general styles are required only for storybook and are not exported from the packages.

@goulinkh
Copy link
Contributor Author

@advl I have applied the change to the react packages as well, could you please take a second look at this.

@goulinkh goulinkh requested a review from advl February 13, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants