Fix container endpoint drop#704
Merged
simondeziel merged 3 commits intocanonical:mainfrom Feb 24, 2026
Merged
Conversation
…containers Signed-off-by: tugbataluy <tugba.taluy@canonical.com>
…cated virtual-machines Signed-off-by: tugbataluy <tugba.taluy@canonical.com>
The /1.0/containers endpoint was removed in LXD 6.x in favour of /1.0/instances. Update the integration test helpers to use the correct endpoint to fix CI failures against latest/edge. Signed-off-by: tugbataluy <tugba.taluy@canonical.com>
There was a problem hiding this comment.
Pull request overview
Updates pylxd to use LXD’s consolidated /1.0/instances endpoint after legacy /1.0/containers and /1.0/virtual-machines were removed, fixing 404s caused by outdated endpoints.
Changes:
- Point
ContainerandVirtualMachinemodels at theinstancesendpoint. - Update integration test helper to create/delete via
instancesinstead ofcontainers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pylxd/models/virtual_machine.py |
Switches model endpoint from legacy virtual-machines to instances. |
pylxd/models/container.py |
Switches model endpoint from legacy containers to instances. |
integration/testing.py |
Updates raw API calls to use instances for container lifecycle in integration tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Following the removal of the
/1.0/containersand/1.0/virtual-machinesendpoints in LXD (lxd#17706), update pylxd to use the/1.0/instancesendpoint exclusively.The Container and VirtualMachine models were subclassing Instance but overriding _endpoint with the now-removed legacy endpoints, causing all operations to return 404. The integration test helper was also directly calling the legacy endpoints via the raw API client.