fix(promote): snapcraft cannot promote from edge with the --yes flag#27
fix(promote): snapcraft cannot promote from edge with the --yes flag#27Guillaumebeuzeboc wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a limitation in snapcraft where promoting from the edge channel cannot be done non-interactively using the --yes flag. The solution pipes yes into the snapcraft promote command and sets the SNAPCRAFT_HAS_TTY environment variable to bypass this restriction.
Key Changes
- Replaced
--yesflag withyes |pipe to provide interactive confirmation - Added
SNAPCRAFT_HAS_TTY: "true"environment variable to simulate TTY presence - Added detailed comments explaining the workaround and referencing the upstream issue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artivis
left a comment
There was a problem hiding this comment.
What is we simply published on candidate instead?
But someone might want to use this workflow to promote from edge to beta. |
|
Well we're not obliged to accommodate every use cases, especially if they deviate much from our opinionated/expected workflow. |
Since not being able to promote from edge with the
--yesflag is by design we must trick snapcraft.