o/devicemgmtstate: add task to queue response messages#16656
Open
st3v3nmw wants to merge 3 commits intocanonical:masterfrom
Open
o/devicemgmtstate: add task to queue response messages#16656st3v3nmw wants to merge 3 commits intocanonical:masterfrom
st3v3nmw wants to merge 3 commits intocanonical:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16656 +/- ##
==========================================
- Coverage 77.57% 77.51% -0.07%
==========================================
Files 1347 1353 +6
Lines 186281 186436 +155
Branches 2449 2449
==========================================
+ Hits 144502 144509 +7
- Misses 33044 33183 +139
- Partials 8735 8744 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wed Feb 25 15:14:36 UTC 2026 Failures:Executing:
Restoring:
Skipped tests from snapd-testing-skip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
queue-mgmt-responsetask. Once a message has been applied (or rejected before reaching the subsystem), this task builds a signed response-message and queues it for transmission on the next store exchange.For messages with a subsystem change, the task retries until the change completes, then calls the handler's
BuildResponseto produce the response body and status. For messages that were rejected or not authorized before dispatch, the response is built directly fromResponseStatus&ResponseReasonon theRequestMessage.Split from #16248. Because the dispatch task is still in review, this PR shares sfrom code with #16547.