many: use dot graph functionality in tests and "snap debug"#16675
Open
andrewphelpsj wants to merge 9 commits intocanonical:masterfrom
Open
many: use dot graph functionality in tests and "snap debug"#16675andrewphelpsj wants to merge 9 commits intocanonical:masterfrom
andrewphelpsj wants to merge 9 commits intocanonical:masterfrom
Conversation
github-actions
bot
added
the
Needs Documentation -auto-
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16675 +/- ##
========================================
Coverage 77.58% 77.59%
========================================
Files 1345 1350 +5
Lines 186890 187241 +351
Branches 2446 2446
========================================
+ Hits 145002 145286 +284
- Misses 33126 33171 +45
- Partials 8762 8784 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sat Feb 28 00:20:41 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skip
|
andrewphelpsj
added
the
Auto rerun spread
pedronis
reviewed
Feb 26, 2026
Contributor
pedronis
left a comment
pedronis
left a comment
There was a problem hiding this comment.
did a pass, some terminology/labeling questions
I also wonder if we should use " []" for consistency for the graphs ?
| } | ||
|
|
||
| // AllTasksForTests returns all tasks currently known to the state, | ||
| // including tasks not linked to any change. |
Contributor
There was a problem hiding this comment.
is linked the right word? do we use task linked to change in other places? belonging to perhaps?
Member
Author
There was a problem hiding this comment.
We use this language in various State methods. For example, the State.Task doc comment:
// Task returns the task for the given ID if the task has been linked to a change.
overlord/dot/dot.go
Outdated
| if err := t.Get("hook-setup", &hooksup); err != nil { | ||
| return "", err | ||
| } | ||
| return fmt.Sprintf("[%s] %s:run-hook[%s]", t.ID(), hooksup.Snap, hooksup.Hook), nil |
Contributor
There was a problem hiding this comment.
did I have this way in the original code? should the ID perhaps go at the ends of labels?
overlord/dot/dottest/dottest.go
Outdated
| return | ||
| } | ||
|
|
||
| chg := st.NewChange("unlinked-tasks", c.TestName()) |
Co-authored-by: Samuele Pedroni <pedronis@lucediurna.net> Co-authored-by: Ernest Lotter <ernest.lotter@canonical.com>
Co-authored-by: Samuele Pedroni <pedronis@lucediurna.net> Co-authored-by: Ernest Lotter <ernest.lotter@canonical.com>
andrewphelpsj
force-pushed
the
split/state-dot-plus
branch
from
652b8db to
753f9f2
Compare
Member
Author
|
Addressed these comments. Sorry, I also rebased against master, so just the last 3 commits are new. |
pedronis
reviewed
Feb 26, 2026
Contributor
pedronis
left a comment
pedronis
left a comment
There was a problem hiding this comment.
thanks for the changes, wondering/nitpick
overlord/dot/dottest/dottest.go
Outdated
|
|
||
| chg := st.NewChange("unlinked-tasks", c.TestName()) | ||
| for _, t := range unlinked { | ||
| chg := st.NewChange("tasks-without-change", c.TestName()) |
Contributor
There was a problem hiding this comment.
do we check the form of that string? otherwise I was really planning to make it not look like a real kind, "tasks w/o change"
Member
Author
There was a problem hiding this comment.
Having the / in there makes it a bit annoying, since we turn that into a path ultimately. But let me know if this is a blocker for you and I'll figure something out.
Contributor
There was a problem hiding this comment.
I would change the way we compute the filename to something vaguely like:
tags := []string{"my-refresh [1]", "MyTest"}
var frags []string
for _, t := range tags {
f := strings.Map(func(r rune) rune {
if unicode.IsLetter(r) || unicode.IsDigit(r) || r == '-' {
return r
}
return ' '
}, t)
f = strings.Join(strings.Fields(f), "_")
frags = append(frags, f)
}
fn := strings.Join(frags, "-")
we could be less strict about what we pass through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables us to integrate dot graph creation into test suites that do not link their tasks to changes.
Additionally, swap out the "snap debug" impl for the implementation from
dot.I know
dottestprobably isn't the best package name, open to alternatives. I didn't just put that stuff indot, since it seems strange to importcheckthere. But maybe that is fine?