tests: enable telnet again and instead remove netcat apparmor profile#16683
Open
alfonsosanchezbeato wants to merge 2 commits intocanonical:masterfrom
Open
tests: enable telnet again and instead remove netcat apparmor profile#16683alfonsosanchezbeato wants to merge 2 commits intocanonical:masterfrom
alfonsosanchezbeato wants to merge 2 commits intocanonical:masterfrom
Conversation
alfonsosanchezbeato
requested review from
Meulengracht,
sergiocazzolato and
valentindavid
alfonsosanchezbeato
added
Run nested
|
Fri Feb 27 21:55:58 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skip
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16683 +/- ##
==========================================
+ Coverage 77.54% 77.59% +0.05%
==========================================
Files 1360 1349 -11
Lines 187256 187161 -95
Branches 2446 2446
==========================================
+ Hits 145200 145230 +30
+ Misses 33278 33158 -120
+ Partials 8778 8773 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # On UC 26.04, the netcat apparmor profile is not allowing access to the | ||
| # ports exposed by qemu, remove it. | ||
| apparmor_parser -R /etc/apparmor.d/nc.openbsd || true |
Contributor
There was a problem hiding this comment.
why it has || true?
could we have instead a check like?
if os.query is-ubuntu-ge 26.04; then
apparmor_parser -R /etc/apparmor.d/nc.openbsd
fi
We will instead remove the netcat apparmor profile. This reverts commit 40770c7.
as it prevents access to ports exposed by qemu.
alfonsosanchezbeato
force-pushed
the
enable-telnet-again
branch
from
880ffd0 to
a5d6714
Compare
Member
Author
|
I've rebased to take also the unsquashfs patch, fingers crossed to get full nested UC26 tests green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The netcat apparmor profile was preventing access to ports exposed by qemu. Remove it from the kernel and revert the previous change that used pipes to workaround the issue, as we want to be able to use telnet to access the serial port of the device.