[DPE-7840] Add get-manifest command to generate manifest of K8s resources without creating them#140
Merged
[DPE-7840] Add get-manifest command to generate manifest of K8s resources without creating them#140
get-manifest command to generate manifest of K8s resources without creating them#140Conversation
theoctober19th
changed the title
get-manifest command to generate manifest of K8s resources without creating them
theoctober19th
commented
Aug 11, 2025
deusebio
approved these changes
Aug 13, 2025
Contributor
deusebio
left a comment
deusebio
left a comment
There was a problem hiding this comment.
LGTM! But the only comment here is that I would definitely have preferred to address the refactoring into its own PR. The refactoring is definitely very very sane, and I would indeed agree with splitting services into more confined submodules. But right now it is not easy to decouple the feature from the copy and paste code. Beside the commit history will hide this refactoring, where a minor feature (adding get-manifest) hides a large refactoring/changes
theoctober19th
force-pushed
the
resource-manifest
branch
from
df4ec84 to
7f1d62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get-manifest command will return the manifest of all the K8s resources that are to be created.
The existing
services.pyfile was too long and messy to to refactor and thus I had to refactor it into multiple modules (while the code remaining intact).The changes I've made on top of refactoring are in the
createmethods of bothKubeCtlInterfaceandLightKubeInterfaceclasses.