Conversation
c097aee to
4f6352a
Compare
bc71390 to
37504e8
Compare
Batalex
commented
Jan 30, 2026
theoctober19th
requested changes
Feb 3, 2026
Member
theoctober19th
left a comment
There was a problem hiding this comment.
Thanks for the much anticipated change!
I've also checked the slight change in the lightkube backend behavior when creating the secret, and yes -- the changes are sane, we probably overlooked that when we implemented lightkube initially.
4f970de to
cf15040
Compare
theoctober19th
approved these changes
Feb 9, 2026
Member
theoctober19th
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the changes!
welpaolo
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated kubectl interface.
I would appreciate extra care in reviewing the change done to
spark8t/kube_interface/lightkube.pywhere I added the following"data": { k: base64.b64encode(v.encode()).decode() for k, v in extra_args.items() } if extra_args else None,to the secret logic creation.
This was necessary to fix the
test_service_account_get_configtest since it previously used the kubectl interface to create the secret even if the fixture was using the lightkube interface.An unintended consequence of removing this interface is that we can now be more precise in the type of the interface used, which means I had to fix a lot of type annotations to make the linter happy, sorry about that...