Skip to content

[MISC] Remove kubectl interface#169

Merged
Batalex merged 5 commits intomainfrom
remove-kubectl
Feb 11, 2026
Merged

[MISC] Remove kubectl interface#169
Batalex merged 5 commits intomainfrom
remove-kubectl

Conversation

@Batalex
Copy link
Contributor

@Batalex Batalex commented Jan 30, 2026

This PR removes the deprecated kubectl interface.

I would appreciate extra care in reviewing the change done to spark8t/kube_interface/lightkube.py where I added the following

                        "data": {
                            k: base64.b64encode(v.encode()).decode()
                            for k, v in extra_args.items()
                        }
                        if extra_args
                        else None,

to the secret logic creation.
This was necessary to fix the test_service_account_get_config test since it previously used the kubectl interface to create the secret even if the fixture was using the lightkube interface.

An unintended consequence of removing this interface is that we can now be more precise in the type of the interface used, which means I had to fix a lot of type annotations to make the linter happy, sorry about that...

@Batalex Batalex self-assigned this Jan 30, 2026
@Batalex Batalex force-pushed the remove-kubectl branch 3 times, most recently from c097aee to 4f6352a Compare January 30, 2026 11:38
@Batalex Batalex marked this pull request as ready for review January 30, 2026 16:13
Copy link
Member

@theoctober19th theoctober19th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the much anticipated change!

I've also checked the slight change in the lightkube backend behavior when creating the secret, and yes -- the changes are sane, we probably overlooked that when we implemented lightkube initially.

Copy link
Member

@theoctober19th theoctober19th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes!

@Batalex Batalex merged commit 658f605 into main Feb 11, 2026
4 checks passed
@Batalex Batalex deleted the remove-kubectl branch February 11, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants