Skip to content

feat: implement customizable horizontal layout for error page#1333

Merged
d-loose merged 11 commits intomainfrom
autoinstall-error-page
Mar 10, 2026
Merged

feat: implement customizable horizontal layout for error page#1333
d-loose merged 11 commits intomainfrom
autoinstall-error-page

Conversation

@d-loose
Copy link
Member

@d-loose d-loose commented Mar 4, 2026

This updates the error page to use the horizontal layout that is used on most other pages, and adds an error parsing method for customization.
I've also added a custom error parser for autoinstall errors:

Screencast.From.2026-03-04.13-42-57.webm

UDENG-8914

@d-loose d-loose added the snap/ubuntu-desktop-bootstrap Raise a snap release PR for ubuntu-desktop-bootstrap label Mar 4, 2026
@d-loose d-loose force-pushed the autoinstall-error-page branch from ffd5116 to e10b145 Compare March 4, 2026 13:02
@d-loose d-loose marked this pull request as ready for review March 4, 2026 13:33
@d-loose d-loose requested a review from juanruitina March 4, 2026 13:33
@juanruitina
Copy link
Contributor

juanruitina commented Mar 5, 2026

Looks pretty good, some minor UI tweaks:

  • Given technical details shows what I understand is a raw error message, I'd suggest to make it monospaced. Also, please make sure font size matches bodyMedium.
  • When clicking on "Import", I'd favour having a more standard behaviour: icon becomes disabled, label is replaced with orange spinning wheel.
  • When error screen shows, remove green "close" button, it's redundant with the window close button, "Restart installer" should be the primary action (in green) instead.
  • When import succeeds, the component that shows the content of the yaml file should have some padding between border and text, you may use the same the "Technical details" box uses.

d-loose added 7 commits March 5, 2026 14:12
When re-starting the installer, we might show the error page again. In
this case the journal stream will be listened to again. This is only
possible if an entirely new stream is created or a broadcast stream that
allows multiple listeners is used.
@d-loose
Copy link
Member Author

d-loose commented Mar 5, 2026

Updated:

Screencast.From.2026-03-05.14-58-20.webm

@matthew-hagemann do you remember if there was a reason to remove the padding from the confirmation page when displaying the autoinstall contents?

padding:
status?.interactive == false ? null : kWizardTilePadding,

Changed in #982

@matthew-hagemann
Copy link
Collaborator

matthew-hagemann commented Mar 5, 2026

Updated:
Screencast.From.2026-03-05.14-58-20.webm

@matthew-hagemann do you remember if there was a reason to remove the padding from the confirmation page when displaying the autoinstall contents?

padding:
status?.interactive == false ? null : kWizardTilePadding,

Changed in #982

@d-loose I see in the PR I wrote that the margins ended up being too large with the autoinstall confirmation text, but I don't remember the specifics 🤔

Looking at the screen shot from then though, the margins are different to whats in your screen recording, so not sure if something else has changed padding wise elsewhere? Maybe my workaround can be safely reverted?

Current:
image

My PR:
image

@juanruitina
Copy link
Contributor

(The padding in the screenshot current looks more sensible)

Copy link
Collaborator

@matthew-hagemann matthew-hagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had one small question re: function signatures of the error parser, but otherwise happy with the approach 🙂

Copy link
Collaborator

@matthew-hagemann matthew-hagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 🙂

@d-loose d-loose merged commit 788a85b into main Mar 10, 2026
34 of 37 checks passed
@d-loose d-loose deleted the autoinstall-error-page branch March 10, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

snap/ubuntu-desktop-bootstrap Raise a snap release PR for ubuntu-desktop-bootstrap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants