feat: implement customizable horizontal layout for error page#1333
feat: implement customizable horizontal layout for error page#1333
Conversation
ffd5116 to
e10b145
Compare
|
Looks pretty good, some minor UI tweaks:
|
When re-starting the installer, we might show the error page again. In this case the journal stream will be listened to again. This is only possible if an entirely new stream is created or a broadcast stream that allows multiple listeners is used.
|
Updated: Screencast.From.2026-03-05.14-58-20.webm@matthew-hagemann do you remember if there was a reason to remove the padding from the confirmation page when displaying the autoinstall contents? Changed in #982 |
@d-loose I see in the PR I wrote that the margins ended up being too large with the autoinstall confirmation text, but I don't remember the specifics 🤔 Looking at the screen shot from then though, the margins are different to whats in your screen recording, so not sure if something else has changed padding wise elsewhere? Maybe my workaround can be safely reverted? |
|
(The padding in the screenshot current looks more sensible) |
matthew-hagemann
left a comment
There was a problem hiding this comment.
Looks good! I had one small question re: function signatures of the error parser, but otherwise happy with the approach 🙂
matthew-hagemann
left a comment
There was a problem hiding this comment.
Thanks! LGTM 🙂


This updates the error page to use the horizontal layout that is used on most other pages, and adds an error parsing method for customization.
I've also added a custom error parser for autoinstall errors:
Screencast.From.2026-03-04.13-42-57.webm
UDENG-8914