refactor: Apply ubuntu lints to all packages (#340)

* refactor: Use ubuntu_lints

* refactor: Fixes to follow the ubuntu_lints rules

* ci: Bump to Flutter 3.16

* fix: Loosen up types where necessary

* ci: Try one 3.13.x

* test: Bump epsilon to 3 for ison baseline alignment

Author: spydon

.github/workflows/ci.yaml

@@ -8,7 +8,7 @@ on:
   workflow_dispatch:
 
 env:
-  FLUTTER_VERSION: '3.13.x'
+  FLUTTER_VERSION: '3.16.x'
 
 jobs:
   analyze:

packages/platform_linux/analysis_options.yaml

@@ -1,38 +1 @@
-include: package:lints/recommended.yaml
-
-analyzer:
-  exclude:
-    - "**/*.g.dart"
-    - "**/*.mocks.dart"
-
-  language:
-     strict-casts: true
-     strict-raw-types: true
-
-linter:
-  rules:
-    always_declare_return_types: true
-    avoid_catches_without_on_clauses: true
-    avoid_equals_and_hash_code_on_mutable_classes: true
-    avoid_types_on_closure_parameters: true
-    cancel_subscriptions: true
-    depend_on_referenced_packages: true
-    directives_ordering: true
-    eol_at_end_of_file: true
-    omit_local_variable_types: true
-    prefer_asserts_in_initializer_lists: true
-    prefer_const_constructors: true
-    prefer_final_in_for_each: true
-    prefer_final_locals: true
-    prefer_null_aware_method_calls: true
-    prefer_null_aware_operators: true
-    prefer_relative_imports: true
-    prefer_single_quotes: true
-    sort_unnamed_constructors_first: true
-    sort_pub_dependencies: true
-    type_annotate_public_apis: true
-    unawaited_futures: true
-    unnecessary_lambdas: true
-    unnecessary_late: true
-    unnecessary_parenthesis: true
-    use_named_constants: true
+include: package:ubuntu_lints/analysis_options.yaml

packages/platform_linux/pubspec.yaml

@@ -14,6 +14,6 @@ dependencies:
   platform: ^3.1.0
 
 dev_dependencies:
-  lints: ^2.0.0
+  ubuntu_lints: ^0.1.0
   mockito: ^5.4.2
   test: ^1.21.0

packages/safe_change_notifier/analysis_options.yaml

@@ -1,40 +1 @@
-include: package:flutter_lints/flutter.yaml
-
-analyzer:
-  language:
-     strict-casts: true
-     strict-raw-types: true
-
-linter:
-  rules:
-    always_declare_return_types: true
-    avoid_catches_without_on_clauses: true
-    avoid_classes_with_only_static_members: false
-    avoid_equals_and_hash_code_on_mutable_classes: true
-    avoid_redundant_argument_values: true
-    avoid_types_on_closure_parameters: true
-    cancel_subscriptions: true
-    depend_on_referenced_packages: true
-    directives_ordering: true
-    eol_at_end_of_file: true
-    omit_local_variable_types: true
-    prefer_asserts_in_initializer_lists: true
-    prefer_const_constructors: true
-    prefer_final_in_for_each: true
-    prefer_final_locals: true
-    prefer_null_aware_method_calls: true
-    prefer_null_aware_operators: true
-    prefer_relative_imports: true
-    prefer_single_quotes: true
-    sized_box_shrink_expand: true
-    sized_box_for_whitespace: true
-    sort_unnamed_constructors_first: true
-    sort_pub_dependencies: true
-    type_annotate_public_apis: true
-    unawaited_futures: true
-    unnecessary_lambdas: true
-    unnecessary_late: true
-    unnecessary_parenthesis: true
-    use_decorated_box: true
-    use_named_constants: true
-    use_super_parameters: true
+include: package:ubuntu_lints/analysis_options.yaml

packages/safe_change_notifier/pubspec.yaml

@@ -17,6 +17,6 @@ dependencies:
   state_notifier: ^0.7.0
 
 dev_dependencies:
-  flutter_lints: ^2.0.0
+  ubuntu_lints: ^0.1.0
   flutter_test:
     sdk: flutter

packages/timezone_map/analysis_options.yaml

@@ -0,0 +1 @@
+include: package:ubuntu_lints/analysis_options.yaml

packages/timezone_map/lib/src/exception.dart

@@ -8,10 +8,8 @@ class GeoException implements Exception {
   const GeoException(this.message, [this.error]);
 
   /// Creates a new exception from a DIO response.
-  factory GeoException.response(Response response) {
-    final message = '${response.statusCode}: ${response.statusMessage}';
-    return GeoException(message, response);
-  }
+  GeoException.response(Response<dynamic> response)
+      : this('${response.statusCode}: ${response.statusMessage}', response);
 
   /// A message describing the exception.
   final String message;

packages/timezone_map/lib/src/geoip.dart

@@ -57,11 +57,11 @@ class GeoIP extends GeoSource {
   @override
   Future<void> cancel() async => _token?.cancel();
 
-  Future<Response> _sendRequest() {
-    return _dio.get(url, cancelToken: _token = CancelToken());
+  Future<Response<T>> _sendRequest<T>() {
+    return _dio.get<T>(url, cancelToken: _token = CancelToken());
   }
 
-  Future<GeoLocation?> _handleResponse(Response response) {
+  Future<GeoLocation?> _handleResponse<T>(Response<T> response) {
     if (response.statusCode != 200) {
       throw GeoException.response(response);
     }

packages/timezone_map/lib/src/geoname.dart

@@ -66,15 +66,17 @@ class Geoname extends GeoSource {
   @override
   Future<void> cancel() async => _token?.cancel();
 
-  Future<Response> _sendRequest(String query) {
-    return _dio.get(
+  Future<Response<T>> _sendRequest<T>(String query) {
+    return _dio.get<T>(
       url,
       queryParameters: <String, String>{'query': query, ...?parameters},
       cancelToken: _token = CancelToken(),
     );
   }
 
-  Future<Iterable<GeoLocation>> _handleResponse(Response response) async {
+  Future<Iterable<GeoLocation>> _handleResponse<T>(
+    Response<T> response,
+  ) async {
     if (response.statusCode != 200) {
       throw GeoException.response(response);
     }

packages/timezone_map/lib/src/map.dart

@@ -42,7 +42,7 @@ class TimezoneMap extends StatelessWidget {
   final TimezoneMapSize size;
 
   /// Requests all timezone map SVG assets to be pre-cached.
-  static Future precacheAssets(BuildContext context) async {
+  static Future<void> precacheAssets(BuildContext context) async {
     final bundle = DefaultAssetBundle.of(context);
     final manifest = await bundle
         .loadString('AssetManifest.json')
@@ -62,7 +62,7 @@ class TimezoneMap extends StatelessWidget {
       return precacheImage(asset, context);
     }
 
-    return Future.wait(manifest.keys.where(filterAsset).map(precacheAsset));
+    await Future.wait(manifest.keys.where(filterAsset).map(precacheAsset));
   }
 
   @override