feat(xdg_icons): replace flutter_svg dependency with jovial_svg

[PureTryOut]

This allows using SVG icons that have for example the <style> attribute set. An example of an icon theme using this is KDE's Breeze. flutter_svg doesn't support this and without it Breeze's dark icons would render as black even though they're supposed to be white.

See dnfield/flutter_svg#105 for context.

Fixes #472.

CC @jpnurmi

[jpnurmi]

LGTM 👍

[jpnurmi]

@PureTryOut I'm not sure why the CI doesn't clearly state it, but the contributor agreement needs to be signed: https://ubuntu.com/legal/contributors

[d-loose]

Looks like the golden test for 'svg file' is failing.
Running it locally, I can see that the expected blue icon doesn't show up correctly:

Expected	Got

Could you have a look @PureTryOut ?

[jpnurmi]

Sorry for the bikeshedding. 😅 Previously, we would pass the preferred size to SvgPicture constructor, but with ScalableImageWidget, we're not passing any size. Does it end up using the SVG viewbox size, which may not match what the user requested? The mismatch should be noticeable when passing a large size to XdgIcon. If there's no way to pass the preferred size, perhaps we need to wrap it with a SizedBox or something?

[PureTryOut]

Sorry for the bikeshedding.

No problem, that's what PR's are for 😉

Does it end up using the SVG viewbox size

Yes. I've set the size in the example to 480 and it only got as big as the viewbox size. Seems just fine.

@PureTryOut I'm not sure why the CI doesn't clearly state it, but the contributor agreement needs to be signed: https://ubuntu.com/legal/contributors

I saw that in CI but didn't figure out where I could sign it. Thanks for the link, I'll read it through.

[PureTryOut]

Not sure why the CLA check is still failing as I've signed it now. I can't sign it again either as it says the email address (the same as on my commits) has already signed it.

[jpnurmi]

Does it end up using the SVG viewbox size

Yes. I've set the size in the example to 480 and it only got as big as the viewbox size. Seems just fine.

The problem is that those arbitrary sizes in the SVG files might significantly differ from the actual requested sizes. For example, requesting a 16px drive-harddisk icon from the Adwaita theme:

Center(
  child: XdgIcon(name: 'drive-harddisk', size: 16, theme: 'Adwaita'),
)

Would show a 128px icon because that specific icon theme happens to ship /usr/share/icons/Adwaita/scalable/devices/drive-harddisk.svg as a scalable icon.

[d-loose]

Not sure why the CLA check is still failing as I've signed it now. I can't sign it again either as it says the email address (the same as on my commits) has already signed it.

Could you try rebasing your branch and see if that fixes it? I've updated the CLA workflow in #478.

[PureTryOut]

@jpnurmi I got your point. I added a SizedBox around them with the given width, should be good now.

@d-loose seems that helped, it went through now 👍

[jpnurmi]

In the latest commit, packages/xdg_icons/test/failures accidentally slipped in. Otherwise LGTM 👍

[PureTryOut]

Woops! That should probably be in a gitignore 😅

[PureTryOut]

Is there anything left to do here?

[d-loose]

Is there anything left to do here?

Sorry for the late reply - I've been quite busy these past weeks.
The changes look good to me, thanks!

One minor thing, would you mind signing your commits?

[PureTryOut]

Done!

[d-loose]

Thank you!