chore: re-add generated files to the repository#480
Merged
d-loose merged 3 commits intocanonical:mainfrom Apr 15, 2025
Merged
Conversation
d-loose
force-pushed
the
restore-generated-files
branch
from
8ed4469 to
7cc31fa
Compare
matthew-hagemann
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've previously removed all generated files from this repo in #454 and added a hook that's supposed to run before publishing packages. It looks like this currently doesn't work correctly, though -
ubuntu_localizations0.5.2misses the generated translation files.I think the easiest solution is to revert to the previous state again and check in all files that need to be included in the published package.