Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
- Coverage 89.11% 87.38% -1.73%
==========================================
Files 100 100
Lines 5519 6530 +1011
==========================================
+ Hits 4918 5706 +788
- Misses 426 642 +216
- Partials 175 182 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The writer didn't need to be exported, so this makes it private.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the default logging method from file logging to using the Windows Event Logger. File logging is still available through the use of the new
--file-log-enabledflag (and its accompanying--event-log-enabledflag, which is enabled by default).You can view logs on Windows 11 by searching for the
Event Viewerapplication and creating a Custom View for all event levels of the "Application" logs.The
eventlogsupport from Golang doesn't seem to include a debug function, so all debug logs are rerouted as info-level logs in the event viewer. In addition, there are event IDs which essentially go unused in this use case (0) as I believe they're mostly OS-specific event types and would be hard to utilize through the logging methods we're currently using.UDENG-2323