-
Notifications
You must be signed in to change notification settings - Fork 108
Update starter pack #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update starter pack #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates us to the newest version (1.3.0 currently) of the Canonical Starter Pack (extension version). Future updates should be easier, as the directory structure now matches the Starter Pack.
Changes made (that don't need review):
docs/dir..githuband.readthedocs.yamlare still at the rootdocs/.custom_wordlist.txtdocs/conf.pydocs/.sphinx/Special points for reviewers
GH Copilot helped me resolve some of the blockers. I'd like a second opinion on these changes to ensure they're acceptable:
docs/.sphinx/_templates/footer.html./Makefiledocs/.sphinx/_templates/header.htmlheader.htmlon the basis thatconf.pycontains the path to thebundle.jsfile and is injected onto every page by default.Feedback button wasn't picking up the link to the issue template:
docs/.sphinx/_templates/page.html: GHC added a<meta>tag to expose thegithub_urlvariable to JS. It also changed from window.onload to DOMContentLoaded for better performance.docs/.sphinx/_static/js/github_issue_links.js: now readsgithub_urlfrom themetatagChecklist