feat(Logo section): Support block level usage#5744
Conversation
|
Thanks @muhammad-ali-pk! Just relaying my message here, I think the documentation could benefit from a short description on where the logo section could be used - something like "This logo section can be used as a block within other patterns such as tiered lists, etc etc" but LGTM otherwise! |
5669d38 to
019e990
Compare
|
Thanks @muhammad-ali-pk , LGTM! Tagging @kim-isaac for visibility and if she'd like to take a look or add any additional comments |
|
@mattea-turic thanks for sharing! Quick check on one thing with @muhammad-ali-pk : |
|
@kim-isaac Since the motivation behind patterns is to prevent users from writing detailed markups from scratch, the Logo block does the exact opposite of that. |
30e661d to
497413a
Compare
404f1b8 to
17e42d9
Compare
3a6a122 to
f90ab66
Compare
f90ab66 to
fa18247
Compare
Done
Fixes WD-33048
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]