Skip to content

feat(Logo section): Support block level usage#5744

Merged
muhammad-ali-pk merged 4 commits intomainfrom
WD-33048
Jan 23, 2026
Merged

feat(Logo section): Support block level usage#5744
muhammad-ali-pk merged 4 commits intomainfrom
WD-33048

Conversation

@muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Jan 21, 2026

Done

  • Added support for using Logo section within other patterns, like Tiered list

Fixes WD-33048

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

@eliman11
Copy link

Thanks @muhammad-ali-pk! Just relaying my message here, I think the documentation could benefit from a short description on where the logo section could be used - something like "This logo section can be used as a block within other patterns such as tiered lists, etc etc" but LGTM otherwise!

@muhammad-ali-pk muhammad-ali-pk linked an issue Jan 21, 2026 that may be closed by this pull request
@mattea-turic
Copy link

Thanks @muhammad-ali-pk , LGTM!

Tagging @kim-isaac for visibility and if she'd like to take a look or add any additional comments

@kim-isaac
Copy link

@mattea-turic thanks for sharing! Quick check on one thing with @muhammad-ali-pk :
Since we already have a Logo block component and it said 'Please use this component if you would like to simply display logos within another section, as it should be treated as a building block that can be inserted into other patterns, without needing to include a title.' on the document, wouldn’t it be possible to apply this component directly within other patterns?
I felt it might be clearer to rely on an existing, ready-to-use component. If there’s a technical reason that requires updating the patterns themselves, please feel free to ignore this!

@muhammad-ali-pk
Copy link
Contributor Author

@kim-isaac Since the motivation behind patterns is to prevent users from writing detailed markups from scratch, the Logo block does the exact opposite of that.
Now that it's possible to cover the block level use with Logo section itself, I believe we should deprecate the Logo block, and remove it from docs in the future.

@muhammad-ali-pk muhammad-ali-pk added Review: QA needed Review: Code needed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jan 22, 2026
Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muhammad-ali-pk muhammad-ali-pk added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jan 23, 2026
@muhammad-ali-pk muhammad-ali-pk merged commit 2946581 into main Jan 23, 2026
15 checks passed
@muhammad-ali-pk muhammad-ali-pk deleted the WD-33048 branch January 23, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Allow logo block]: <Tiered list>

6 participants