Skip to content

feat(icons): Add storage volume, storage pool and storage bucket icons#5752

Merged
kimanhou merged 1 commit intocanonical:mainfrom
kimanhou:icons-storage
Feb 2, 2026
Merged

feat(icons): Add storage volume, storage pool and storage bucket icons#5752
kimanhou merged 1 commit intocanonical:mainfrom
kimanhou:icons-storage

Conversation

@kimanhou
Copy link
Contributor

@kimanhou kimanhou commented Feb 2, 2026

Done

Adds icons ofr storage pool (p-icon--storage-pool), storage volume (p-icon--storage-volume) and storage bucket (p-icon--storage-bucket)

Fixes BRND-3075

QA

  • Open icons docs and verify p-icon--storage-pool, p-icon--storage-volume and p-icon--storage-bucket have been added to the recently added icons section.
    • Verify p-icon--generative-ai, p-icon--ignored and p-icon--vulnerable have been moved to the additional icons list (it was previously a "new" icon).
    • Verify the @include vf-p-icon--storage-pool;, @include vf-p-icon--storage-volume; and @include vf-p-icon--storage-bucket; are included in the import instructions on this page.
  • Open the additional icons example and verify the storage volume, storage pool and storage bucket examples appear as expected in all themes.
    Review 4.43.0 release notes

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

image image image image

@kimanhou kimanhou self-assigned this Feb 2, 2026
@kimanhou kimanhou added Review: Design needed Review: QA needed Review: Code needed Feature 🎁 New feature or request Review: Percy needed This PR needs a review of Percy for visual regressions labels Feb 2, 2026
@webteam-app
Copy link

@kimanhou kimanhou force-pushed the icons-storage branch 2 times, most recently from 7c97159 to d6dc88a Compare February 2, 2026 11:04
@kimanhou kimanhou marked this pull request as ready for review February 2, 2026 11:18
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for getting those icons from design and adding them here!

Code LGTM, tiny issue with the linter on the scss:

image

@kim-isaac
Copy link

@kimanhou LGTM! Thanks

@kimanhou kimanhou merged commit ea8d6e0 into canonical:main Feb 2, 2026
8 checks passed
@kimanhou kimanhou deleted the icons-storage branch February 2, 2026 16:03
@advl
Copy link
Contributor

advl commented Feb 2, 2026

Just saw this - LGTM as well. Thanks to all involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature 🎁 New feature or request Review: Code needed Review: Design +1 Review: Percy needed This PR needs a review of Percy for visual regressions Review: QA needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants