-
Notifications
You must be signed in to change notification settings - Fork 220
Fix check for retransmission of discarded block segments #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
acolomb
merged 12 commits into
canopen-python:master
from
samsamfire:sdo-block-upload-retransmit-fix
Jun 11, 2025
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1a74fb6
Fixed : retransmission of discarded segments starts at beginning of n…
samsamfire 33aa620
Test : add a block retransmit test. This test passes with this implem…
samsamfire 7fe2c71
Comment : fixed wrong value in comment
samsamfire ab4d150
Comment : better comments on the different steps of the block
samsamfire 2692989
Fix docstring.
acolomb 43e9377
Fix quoting style to match surrounding code.
acolomb ff12cb4
Use test framework assertion instead of plain assert.
acolomb 7822ca4
Merge branch 'canopen-python:master' into sdo-block-upload-retransmit…
samsamfire df4af56
Fixed : moved comments up (wrong line)
samsamfire 37c6e4b
Changed : replace double x34 with x34/x33 to make it clearer that the…
samsamfire a0a40b8
Changed : reset _ackseq every block
samsamfire 93ed50b
Update test/test_sdo.py
acolomb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why the
self._ack_block()call doesn't simply reset theself._ackseqattribute to zero in all cases. Then this check would be fine as is?Just thinking out loud, let's hear your thoughts on why this is the better place to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsamfire Are you still onto this?