Merged
Conversation
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
fenollp
changed the title
bkirwi
reviewed
Jul 28, 2024
Collaborator
bkirwi
left a comment
bkirwi
left a comment
There was a problem hiding this comment.
Looking it over, it seems like stopwatch is only used in a very limited way that would be quite straightforward to replace with the stdlib Instant::elapsed etc. -- might be nicer than depending on a git rev here? (I can take a stab at that change if it's a hassle...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bumped all the deps except
libcand:once_cellcan be dropped, if we're alright requiring rust >=1.80aabb-quadtreeis causing me compilation issues...atomicrequires some work (I'd sayimpl From<std::sync::atomic::AtomicI64> for DrawMode, allowing to dropatomic)