Open
Conversation
github-actions
bot
added
the
Jira: Not Linked
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 487 488 +1
Lines 21855 21869 +14
Branches 1014 1014
=======================================
+ Hits 20450 20464 +14
Misses 1252 1252
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
Jira: Linked
aduane
requested changes
Mar 5, 2026
plugin_runner/tests/fixtures/plugins/test_batch_commit/protocols/my_protocol.py
Outdated
Show resolved
Hide resolved
Add BatchCommitCommandEffect and _commit_payload_for_batch() to enable committing multiple commands in a single batch operation, mirroring the existing BATCH_ORIGINATE_COMMANDS pattern.
Verifies that a plugin can import BatchCommitCommandEffect, construct command instances with command_uuid, and produce the correct effect payload through the RestrictedPython sandbox.
Address PR feedback: use "handler" terminology instead of "protocol" (which is reserved for clinical protocols).
aduane
approved these changes
Mar 10, 2026
Collaborator
aduane
left a comment
aduane
left a comment
There was a problem hiding this comment.
This looks good, but the home-app PR has some comments Rui left that need attention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://canvasmedical.atlassian.net/browse/KOALA-4385
home-app: https://github.com/canvas-medical/canvas/pull/18775
Add BatchCommitCommandEffect and _commit_payload_for_batch() to enable committing multiple commands in a single batch operation, mirroring the existing BATCH_ORIGINATE_COMMANDS pattern.