Fix excessive memory growth warning to log plugin name instead of None#1560
Open
beaugunderson wants to merge 1 commit intomainfrom
Open
Fix excessive memory growth warning to log plugin name instead of None#1560beaugunderson wants to merge 1 commit intomainfrom
beaugunderson wants to merge 1 commit intomainfrom
Conversation
The warning called is_plugin_caller() in the finally block where the call stack no longer reflects the plugin context, resulting in "running None". Now uses extra_tags["plugin"] (preferred) or the name parameter instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Jira: Not Linked
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
=======================================
Coverage 93.56% 93.56%
=======================================
Files 487 487
Lines 21850 21850
Branches 1013 1013
=======================================
Hits 20445 20445
Misses 1252 1252
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djantzen
approved these changes
Mar 9, 2026
Contributor
djantzen
left a comment
djantzen
left a comment
There was a problem hiding this comment.
Thanks for catching. The metrics collected during plugin runtime show up in Grafana attributed to the plugin, but not yet for plugin load operations. Could we also add track_plugin_usage=True to def load_or_reload_plugin in plugin_runner.py?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning called is_plugin_caller() in the finally block where the call stack no longer reflects the plugin context, resulting in "running None". Now uses extra_tags["plugin"] (preferred) or the name parameter instead.
(Investigator wrote this code, I just had to open the PR since it failed that step)