[AIDAPP-928]: Enhance the text editor for Engagement (Email Templates & Messages)#950
Open
payal-canyon wants to merge 10 commits intomainfrom
Open
[AIDAPP-928]: Enhance the text editor for Engagement (Email Templates & Messages)#950payal-canyon wants to merge 10 commits intomainfrom
payal-canyon wants to merge 10 commits intomainfrom
Conversation
payal-canyon
force-pushed
the
features/AIDAPP-928
branch
2 times, most recently
from
98d64d5 to
9aae5fe
Compare
payal-canyon
added
the
Change Type | Content or Styling Update
payal-canyon
force-pushed
the
features/AIDAPP-928
branch
from
42840e2 to
7e4d19b
Compare
payal-canyon
force-pushed
the
features/AIDAPP-928
branch
from
7e4d19b to
e895a22
Compare
danharrin
requested changes
Mar 27, 2026
…t and body fields, enhancing content management and image handling capabilities.
…oversized image dimensions in engagement tables
…and CreateEngagementBatch; introduce team template filter in BulkEngagementAction and RelationManagerSendEngagementAction.
… tag merging for rich content in Engagement and EngagementBatch models.
…ns; update Engagement model to handle body content and merge data more efficiently.
payal-canyon
force-pushed
the
features/AIDAPP-928
branch
from
e895a22 to
f960b12
Compare
…tent and GenerateTipTapBodyJson actions
…yContent and GenerateTipTapBodyJson actions
danharrin
requested changes
Mar 27, 2026
Contributor
danharrin
left a comment
danharrin
left a comment
There was a problem hiding this comment.
I think the $set() for the body in BulkDraftWithAiAction and RelationManagerDraftWithAiAction need to be updated to use the RichContentRenderer like we do for Olympus, so we set the state of the rich editor to be the TipTap schema array and NOT HTML like we had before.
danharrin
requested changes
Mar 27, 2026
Contributor
danharrin
left a comment
danharrin
left a comment
There was a problem hiding this comment.
Does RelationManagerSendEngagementAction need to set the model(Engagement) inside the form schema like we do on Olympus? To ensure that it can load in the available merge tags, etc?
Orrison
requested changes
Mar 27, 2026
Contributor
Orrison
left a comment
Orrison
left a comment
There was a problem hiding this comment.
@payal-canyon since @danharrin is OOO please re-request my review once you address the feedback he left
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket(s) or GitHub Issue
Technical Description
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.