AEM implementation #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
…Solace Message Broker.
t-bonk
requested review from
StefanHenke and
mofterdinger
and removed request for
beckermarc and
sjvans
StefanHenke
reviewed
Mar 24, 2025
...va/com/sap/cds/feature/messaging/aem/client/binding/AemManagementOauth2PropertySupplier.java
Show resolved
Hide resolved
.../main/java/com/sap/cds/feature/messaging/aem/client/binding/AemAuthorizationServiceView.java
Outdated
Show resolved
Hide resolved
...d-event-mesh/src/main/java/com/sap/cds/feature/messaging/aem/client/AemManagementClient.java
Outdated
Show resolved
Hide resolved
StefanHenke
reviewed
Mar 24, 2025
...mesh/src/main/java/com/sap/cds/feature/messaging/aem/jms/AemMessagingConnectionProvider.java
Outdated
Show resolved
Hide resolved
StefanHenke
reviewed
Mar 24, 2025
...mesh/src/main/java/com/sap/cds/feature/messaging/aem/jms/AemMessagingConnectionProvider.java
Show resolved
Hide resolved
StefanHenke
reviewed
Mar 27, 2025
...d-event-mesh/src/main/java/com/sap/cds/feature/messaging/aem/client/AemManagementClient.java
Outdated
Show resolved
Hide resolved
...e-advanced-event-mesh/src/main/java/com/sap/cds/feature/messaging/aem/client/RestClient.java
Outdated
Show resolved
Hide resolved
...e-advanced-event-mesh/src/main/java/com/sap/cds/feature/messaging/aem/client/RestClient.java
Show resolved
Hide resolved
...va/com/sap/cds/feature/messaging/aem/client/binding/AemManagementOauth2PropertySupplier.java
Show resolved
Hide resolved
StefanHenke
reviewed
Mar 27, 2025
...e-advanced-event-mesh/src/main/java/com/sap/cds/feature/messaging/aem/client/RestClient.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefan Henke <[email protected]>
Contributor
|
lgtm |
Contributor
|
please consider #5 regarding the failing tests |
Contributor
|
|
Contributor
Author
@sjvans are you referring to the simplified binding with only one URI? |
Contributor
i'll adjust the pr asap |
Contributor
|
ahhh, sorry, i wanted to comment on #5 🙈 |
StefanHenke
approved these changes
Mar 31, 2025
Contributor
StefanHenke
left a comment
StefanHenke
left a comment
There was a problem hiding this comment.
lgtm. two more minor comments
...main/java/com/sap/cds/feature/messaging/aem/client/binding/AemAuthenticationServiceView.java
Outdated
Show resolved
Hide resolved
...main/java/com/sap/cds/feature/messaging/aem/client/binding/AemAuthenticationServiceView.java
Outdated
Show resolved
Hide resolved
…ure/messaging/aem/client/binding/AemAuthenticationServiceView.java Co-authored-by: Stefan Henke <[email protected]>
…ure/messaging/aem/client/binding/AemAuthenticationServiceView.java Co-authored-by: Stefan Henke <[email protected]>
dimamost
requested changes
Apr 1, 2025
...d-event-mesh/src/main/java/com/sap/cds/feature/messaging/aem/client/AemManagementClient.java
Outdated
Show resolved
Hide resolved
dimamost
requested changes
Apr 1, 2025
...d-event-mesh/src/main/java/com/sap/cds/feature/messaging/aem/client/AemManagementClient.java
Outdated
Show resolved
Hide resolved
dimamost
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advanced Event Mesh for CAP Java