saner setup where we ignore tls objects

Author: rlindner81

src/redis-adapter.js

@@ -12,7 +12,7 @@ const { CfEnv } = require("./shared/cf-env");
 const { Logger } = require("./shared/logger");
 const { HandlerCollection } = require("./shared/handler-collection");
 const { Semaphore } = require("./shared/semaphore");
-const { tryJsonParse, isObject } = require("./shared/static");
+const { tryJsonParse } = require("./shared/static");
 
 const COMPONENT_NAME = "/RedisAdapter";
 const VERROR_CLUSTER_NAME = "RedisAdapterError";
@@ -108,9 +108,13 @@ const _createClientBase = (clientName) => {
           host,
           port,
           ...__clientOptions?.socket,
+          // NOTE: Azure and GCP have an object in their service binding credentials under tls, however it's filled
+          //   with nonsensical values like:
+          //   - "ca": "null", a literal string spelling null, or
+          //   - "server_ca": "null", where "server_ca" is not a recognized property that could be set on a socket.
+          //   For reference: https://nodejs.org/docs/latest-v22.x/api/tls.html#tlscreatesecurecontextoptions
+          // NOTE: We normalize the tls value to boolean here, because @redis/client needs a boolean.
           tls: !!(__clientOptions?.socket?.tls ?? tls),
-          ...(isObject(tls) && tls),
-          ...(isObject(__clientOptions?.socket?.tls) && __clientOptions?.socket?.tls),
         },
       };
 

test/__snapshots__/redis-adapter.test.js.snap

@@ -33,7 +33,6 @@ exports[`redis-adapter test _createClientBase on CF | AZURE 1`] = `
     "password": "mock-password",
     "pingInterval": 300000,
     "socket": {
-      "ca": "null",
       "host": "redis-389395bc-9765-4d9a-ba6b-7252c136abab.redis.cache.windows.net",
       "port": 6380,
       "tls": true,
@@ -50,7 +49,6 @@ exports[`redis-adapter test _createClientBase on CF | GCP 1`] = `
     "socket": {
       "host": "10.160.68.75",
       "port": 6378,
-      "server_ca": "null",
       "tls": true,
     },
   },