Skip to content

Support attachments with custom primary key fields (non-ID keys) #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+30 −20
Open

Support attachments with custom primary key fields (non-ID keys) #230

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
937fca8
refactor: remove hardcoded regex in favor of CAP-native key parsing v…
RoshniNaveenaS Jul 25, 2025
5eadef6
fix: enhance nonDraftUpload to support arbitrary key names using req.…
RoshniNaveenaS Jul 29, 2025
fd0ca7e
fix: refactor readAttachment to support dynamic keys using req.params
RoshniNaveenaS Jul 29, 2025
1e93f87
fix: update validateAttachment to support key extraction via req.para…
RoshniNaveenaS Jul 29, 2025
3329827
Update plugin.js
RoshniNaveenaS Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 30 additions & 20 deletions lib/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ const cds = require("@sap/cds/lib")
const LOG = cds.log("attachments")
const { extname } = require("path")
const DEBUG = LOG._debug ? LOG.debug : undefined
const attachmentIDRegex = /\/\w+\(.*ID=([0-9a-fA-F-]{36})/

cds.on(cds.version >= "8.6.0" ? "compile.to.edmx" : "loaded", unfoldModel);
function unfoldModel (csn) {
Expand Down Expand Up @@ -82,35 +81,46 @@ cds.once("served", async function registerPluginHandlers () {
/* removing case condition for mediaType annotation as in our case binary value and metadata is stored in different database */

req?.query?.SELECT?.columns?.forEach((element) => {
if (element.as === '[email protected]' && element.xpr) {
delete element.xpr
element.ref = ['mimeType']
}
})

if (req?.req?.url?.endsWith("/content")) {
const attachmentID = req.req.url.match(attachmentIDRegex)[1]
const status = await AttachmentsSrv.getStatus(req.target, { ID: attachmentID })
const scanEnabled = cds.env.requires?.attachments?.scan ?? true
if (scanEnabled && status !== 'Clean') {
req.reject(403, 'Unable to download the attachment as scan status is not clean.')
}
if (element.as === '[email protected]' && element.xpr) {
delete element.xpr;
element.ref = ['mimeType'];
}
});

if (req?.req?.url?.endsWith("/content")) {
const attachmentKey = req.params?.[1];
if (!attachmentKey?.ID) return req.reject(400, 'Missing attachment key in request');
const status = await AttachmentsSrv.getStatus(req.target, attachmentKey);
const scanEnabled = cds.env.requires?.attachments?.scan ?? true;
if (scanEnabled && status !== 'Clean') {
req.reject(403, 'Unable to download the attachment as scan status is not clean.');
}
}
}

async function readAttachment ([attachment], req) {
if (!req?.req?.url?.endsWith("/content") || !attachment || attachment?.content) return
let keys = { ID: req.req.url.match(attachmentIDRegex)[1] }
const keys = req.params?.[1];
if (!keys) return;
let { target } = req
attachment.content = await AttachmentsSrv.get(target, keys, req) //Dependency -> sending req object for usage in SDM plugin
}

async function nonDraftUpload(req, target) {
if (req?.content?.url?.endsWith("/content")) {
const attachmentID = req.content.url.match(attachmentIDRegex)[1];
AttachmentsSrv.nonDraftHandler(target, { ID: attachmentID, content: req.content });
}
}
try {
if (req?.content?.url?.endsWith("/content")) {
const attachmentID = req.params?.[1]?.ID;
if (!attachmentID) return req.reject(400, 'Missing attachment key in URL');
await AttachmentsSrv.nonDraftHandler(target, {
ID: attachmentID,
content: req.content
});
}
} catch (err) {
LOG.error('[NON_DRAFT_UPLOAD_ERROR]', err);
throw Object.assign(new Error('Non-draft attachment upload failed.'), { statusCode: 500 });
}
}
})

function validateAttachmentSize (req) {
Expand Down
Loading