Skip to content

fix(deps): update dependency hdb to v2 #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(deps): update dependency hdb to v2 #1266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b799d3f
fix(deps): update dependency hdb to v2
renovate[bot] Jul 10, 2025
756751e
use hana data format version 7 for bool support
johannes-vogel Jul 10, 2025
29dbf5b
Merge branch 'main' into renovate/hdb-2.x
johannes-vogel Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions hana/lib/drivers/hdb.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,13 @@ const { Readable, Stream, promises: { pipeline } } = require('stream')
const { StringDecoder } = require('string_decoder')
const { text } = require('stream/consumers')

const cds = require('@sap/cds')
const hdb = require('hdb')
const iconv = require('iconv-lite')

const { driver, prom, handleLevel } = require('./base')
const { resultSetStream } = require('./stream')
const { wrap_client } = require('./dynatrace')

if (cds.env.features.sql_simple_queries === 3) {
// Make hdb return true / false
const Reader = require('hdb/lib/protocol/Reader.js')
Reader.prototype._readTinyInt = Reader.prototype.readTinyInt
Reader.prototype.readTinyInt = function () {
const ret = this._readTinyInt()
return ret == null ? ret : !!ret
}
}

const credentialMappings = [
{ old: 'certificate', new: 'ca' },
{ old: 'encrypt', new: 'useTLS' },
Expand All @@ -35,6 +24,7 @@ class HDBDriver extends driver {
constructor(creds) {
creds = {
fetchSize: 1 << 16, // V8 default memory page size
dataFormatSupport: 7, // with 7 hana supports booleans
...creds,
}

Expand Down
2 changes: 1 addition & 1 deletion hana/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"dependencies": {
"@cap-js/db-service": "^2.1.1",
"hdb": "^0.19.5"
"hdb": "^2.0.0"
},
"peerDependencies": {
"@sap/hana-client": "^2",
Expand Down
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.