-
Notifications
You must be signed in to change notification settings - Fork 22
fix: date input conversion #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
// The following allows passing in ISO strings with non-zulu | ||
// timezones and converts them into zulu dates and times | ||
Date: e => e === '?' ? e : `strftime('%Y-%m-%d',${e})`, | ||
Date: e => `strftime('%Y-%m-%d',${e})`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the other InputConverters need the same adjustment?
Strange, I see that the tests are failing in the pipeline... I'll check, they are running fine locally. |
SQlite tests are fine, looks like PG and HANA do behave differently though (compliance test suite is run against all DBs) |
@patricebender Postgres looks fine locally now, but I have some trouble running the HANA testcases locally. |
Testcases look good now! I think this is ready for review. |
This is an attempt to fix #1002. I'm not sure though if this is the right approach, maybe there was a reason I don't understand for the condition (
e => e === '?' ? e
) that I have removed.The new testcase fails without the adjustment.
With the fix, the following SQL will be executed:
Before the fix, it was like this: