chore: re-write filter at from.at(-1) into queries where
#1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a preparation for #1361 and it also makes our lifes easier as the infix filter at this place is semantically equivalent to a regular `where` clause.
patricebender
requested review from
BobdenOs,
David-Kunz,
danjoa,
johannes-vogel,
sjvans and
stewsk
as code owners
patricebender
commented
Oct 6, 2025
| expect(query).to.deep.equal( | ||
| cds.ql`SELECT from bookshop.Books as Books {Books.ID} | ||
| WHERE (Books.price > 5) and (Books.price < 12.13) | ||
| WHERE Books.price < 12.13 and Books.price > 5 |
There was a problem hiding this comment.
only wrap in parens if really needed
patricebender
commented
Oct 6, 2025
| } | ||
| WHERE EXISTS ( | ||
| SELECT 1 from bookshop.Books as $B where $B.author_ID = $a.ID | ||
| SELECT 1 from bookshop.Books as $B2 where $B2.author_ID = $a.ID |
There was a problem hiding this comment.
alias order changes because infix filter at leaf are put at the very front of the queries where
patricebender
commented
Oct 23, 2025
Comment on lines
-83
to
-84
| //(SMW) TODO I'd prefer to have the cond from the filter before the cond coming from the WHERE | ||
| // which, by the way, is the case in tests below where we have a path in FROM -> ??? |
There was a problem hiding this comment.
done according to your wish @stewsk
stewsk
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a preparation for #1361 and it also makes our lifes easier as the infix filter at this place is semantically equivalent to a regular
whereclause.