fix(@cds.search): properly exclude an association from being searched
#1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is a shame that I had no tests for this in place. :( --> With this change, excluding an association from being searched does not result in the association __being__ searched. The annotation value was just not considered.
patricebender
requested review from
BobdenOs,
David-Kunz,
danjoa,
johannes-vogel,
sjvans and
stewsk
as code owners
David-Kunz
approved these changes
Oct 23, 2025
Merged
patricebender
pushed a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 2.6.0</summary> ## [2.6.0](db-service-v2.5.1...db-service-v2.6.0) (2025-10-23) ### Added * **`flattening`:** allow flattening of `n`-ary structures in `list` ([#1337](#1337)) ([7ec18f2](7ec18f2)) * **`flattening`:** allow flattening of structures with exactly one leaf ([7ec18f2](7ec18f2)) ### Fixed * **`@cds.search`:** properly exclude an association from being searched ([#1385](#1385)) ([9ed4245](9ed4245)) * tree table with expand ([#1363](#1363)) ([bdad412](bdad412)) </details> <details><summary>hana: 2.3.4</summary> ## [2.3.4](hana-v2.3.3...hana-v2.3.4) (2025-10-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @cap-js/db-service bumped from ^2.5.1 to ^2.6.0 </details> <details><summary>postgres: 2.0.6</summary> ## [2.0.6](postgres-v2.0.5...postgres-v2.0.6) (2025-10-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @cap-js/db-service bumped from ^2 to ^2.6.0 </details> <details><summary>sqlite: 2.0.4</summary> ## [2.0.4](sqlite-v2.0.3...sqlite-v2.0.4) (2025-10-23) ### Dependencies * The following workspace dependencies were updated * dependencies * @cap-js/db-service bumped from ^2 to ^2.6.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is a shame that I had no tests for this in place. :(
--> With this change, excluding an association from being searched does not result in the association being searched. The annotation value was just not considered.