Open
Conversation
PDT42
requested review from
BobdenOs,
danjoa,
johannes-vogel,
patricebender,
sjvans and
stewsk
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a field type is specified as
Decimalfor sqlite, we will accept that type as is. The cds-compiler plans to enable manually setting an "affinity" that allows to have decimal type fields be configured asREAL_DECIMALin sqlite, which according to the sqlite docs, will cause the column to be interpreted as aREAL.We may want to wait for the
cdscanddbflags to be aligned, before merging this.