Skip to content

Refactor #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Refactor #84

wants to merge 10 commits into from

Conversation

daogrady
Copy link
Contributor

@daogrady daogrady commented Sep 3, 2025

No description provided.

swaldmann
swaldmann reviewed Sep 3, 2025
View reviewed changes
Copy link
Contributor

@swaldmann swaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks definitely tidier than before at first sight. One observation: without the new lib/compile/csdl.d.ts we are at 674+,588-, so 86 LoC more than before, without the added file header comments more like ~50. Within limits for a repo of this size imo.

@daogrady daogrady mentioned this pull request Sep 8, 2025
Open
@daogrady
Copy link
Contributor Author

daogrady commented Sep 8, 2025

Despite how promising these changes looked and how they passed the test suites, the output on stakeholder projects were totally garbled.
I therefore cherrypicked the useful parts (plus some additional changes) over to #85 and will close this PR.

@daogrady daogrady closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaldmann swaldmann swaldmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daogrady @swaldmann